Update boost to version 1.64 + minor enhancements #194

pgiffuni · 2023-12-23T20:25:46Z

Add some headers to the existing 1.55 boost internal package.

Make cleaner usage of boost's sinc_pi functionality. There is no need to limit the policy.

We normally don't install all the headers availabe in boost. There is an interesting set of functionalities like multiprecision and odeint that while we are not using, but would be interesting to have available. This is done to ease future boost updates but also in the hopes of making it possible to use this functionality in a near future. No functional change expected.

Modern processors should handle this without any trouble.

pgiffuni · 2023-12-23T20:50:31Z

Sorry for the PR mess.
The new target is version 1.64: it builds fine on FreeBSD. It has sufficient functionality to justify the update.

Other than the updates and bug fixes, this version works really well with older compilers and systems and is the last one to include TR1: which we use as a last resort for really old systems lacking standard C++ compliance. https://www.boost.org/users/history/version_1_64_0.html

Pilot-Pirx · 2023-12-26T17:42:10Z

Builds on Windows with 1.55.
Breaks with 1.64 in module sal:

Building module sal

Entering /cygdrive/c/Source/openoffice/main/sal/inc

Entering /cygdrive/c/Source/openoffice/main/sal/osl/w32

Making: all_cpposl.dpslo
Making: all_cpposl.dpobj

Entering /cygdrive/c/Source/openoffice/main/sal/textenc

Making: all_textenc.dpslo
Making: all_textenc.dpobj

Entering /cygdrive/c/Source/openoffice/main/sal/rtl/source

Making: all_cpprtl.dpslo
Making: all_cpprtl.dpobj
--- ALWAYSDBGFILES ---
--- ALWAYSDBGFILES OVER ---

Entering /cygdrive/c/Source/openoffice/main/sal/systools/win32/uwinapi

Entering /cygdrive/c/Source/openoffice/main/sal/systools/win32/onlineupdate

Entering /cygdrive/c/Source/openoffice/main/sal/osl/all

Compiling: sal/osl/all/debugbase.cxx
C:/Source/openoffice/main/solver/450/wntmsci12.pro/inc\boost/ref.hpp(15) : fatal error C1083: Cannot open include file: 'boost/core/ref.hpp': No such file or directory
dmake: Error code 2, while making '../../wntmsci12.pro/obj/debugbase.obj'

1 module(s):
sal
need(s) to be rebuilt

Reason(s):

ERROR: error 65280 occurred while making /cygdrive/c/Source/openoffice/main/sal/osl/all

When you have fixed the errors in that module you can resume the build by running:

    build --from sal

pgiffuni · 2023-12-26T20:07:18Z

The latest version should work.

Needed for Windows build.

Pilot-Pirx · 2023-12-31T11:05:54Z

I am now able to build further on Windows, but I get a lot of these warnings and the build stops at some point:

pgiffuni · 2023-12-31T13:22:02Z

Bummer! This version of boost was tested was tested on our supported compiler upstream so it might be some local build issue.
Please merge the 1.55 header updates. I won't have time to work on further updates to boost but I'll keep the patch for playing with 1.64 in the future.

Pilot-Pirx · 2023-12-31T13:42:25Z

I will try to do that.
For the moment I will change this to a Draft.

pgiffuni · 2023-12-31T14:10:49Z

Looking at your d.lst changes, there is a dll and respective /detail directory which may be needed for windows. Those didn't exist in 1.55

Pilot-Pirx · 2023-12-31T14:22:53Z

I will try that!
Next year... ;-)

Builds fine on Windows now.

Pilot-Pirx · 2024-01-07T04:56:17Z

Builds on Windows now:
https://www.dropbox.com/scl/fi/5ooqaxvdec34l30v99xmo/Apache_OpenOffice_4.5.0_Win_x86_install_en-US_boost.exe?rlkey=k5r4bwmxrvzlzraypu42jod2c&dl=0

Pilot-Pirx · 2024-01-07T04:58:29Z

@jimjag Can you please try to build on macOS/Linux?
I think this would be nice for AOO 4.2.0-Dev5.

pgiffuni · 2024-01-13T21:01:09Z

@Pilot-Pirx Thanks so much for finishing the bits for Windows.

Since it's getting so long to merge(!), let me provide some motivation:

We currently make limited use of boost, so the boost update will provide some fixes and performance enhancements, but perhaps more important is that it provides functionality that modern languages would regularly provide and that are currently unavailable in our older C++ environment.
AOO is about 80% C++ code and it's currently stuck in an older version of that language supported by a MSVC 2008.
Keeping a too old version of boost will make it increasingly difficult to compile AOO on newer compilers; putting up a too recent version of boost will make it imposible to build AOO with the older compilers. The 1.64 version from 2017 seems to be in the right place for all the supported platforms/compilers.

Pilot-Pirx · 2024-01-13T21:43:25Z

Hi Pedro,

I am highly motivated to merge this PR but I didn't want to do it without being sure that it builds on macOS and Linux.
We definitely want to have this in AOO 4.2.0 Developer Release 5 (hopefully end of the month).

Since it builds on BSD how high is the probability that it also builds on macOS?

pgiffuni · 2024-01-14T02:03:52Z

Since it builds on BSD how high is the probability that it also builds on macOS?

Very high .. FreeBSD and macOS share most of libc and FreeBSD adopted natively LLVM as well, but there are sufficient differences that one can't be 100% sure.

The one thing that gives us relative confidence is that upstream tested all the OS/compiler combinations we are interested in:

Linux:

Clang: 3.0, 3.8.1, 3.9.1
GCC: 4.4.7, 4.5.3, 4.6.3, 4.7.2, 6.2.0

OS X:

Apple Clang: 7.0.2

Windows:

Visual C++: 7.1, 8.0, 9.0, 10.0, 11.0, 12.0, 14.0

FreeBSD:

Clang: 3.8

Pilot-Pirx · 2024-01-14T09:50:44Z

Thanks for the info!

I can merge it, although it still is a "shot in the dark" for me.

For Linux I can see the results from our buildbot (trunk):
https://nightlies.apache.org/openoffice/install/linux64/?C=M;O=D

If successful, I would cherry-pick for AOO42X.

@jimjag What do you think?

pgiffuni · 2024-01-14T18:03:48Z

Can you cherrypick the 1.55 updates and squash the 1.64 update in a different commit?
I did try to make it easier for you guys to revert in case something went really wrong although it seems it won't be the case.

Pilot-Pirx · 2024-01-14T18:39:27Z

Yes, I can "Squash and merge" it to trunk.
In fact I will do it now. If something goes wrong it is just one commit to revert...

If the Linux buildbot is successful, I will cherry-pick it to AOO42X tomorrow.

This reverts commit fa664a2.

Pilot-Pirx · 2024-01-14T22:55:56Z

Buildbot does not build:

1 module(s):
sal
need(s) to be rebuilt

Reason(s):

ERROR: error 65280 occurred while making /home/buildslave/slave/openoffice-linux64-nightly/build/main/sal/rtl/source

When you have fixed the errors in that module you can resume the build by running:

build --from sal

Pilot-Pirx · 2024-01-14T22:56:23Z

Not being a developer I will now step back and let others take over...

Feel free to reopen this PR.

pgiffuni · 2024-01-23T02:58:10Z

I wish the 1.55 changes had been merged separately. The sinc_pi change was useful despite the version.

In any case it appears that the boost build per-se didn't fail but that the built left missing headers unistalled that are required by the linux port. I can't really follow up at this time as I don't have a linux box available to test.

Pilot-Pirx · 2024-02-05T22:15:44Z

Unfortunately GitHub does not seem to allow to re-open a PR once it was merged...

If you don't mind (and my time permits) I would like to do "remakes" of your original PR.
I think the sinc_pi change can be merged quickly.

pgiffuni added 2 commits December 23, 2023 15:21

Let boost promote to double the sinc_pi() operation.

2f2163b

Modern processors should handle this without any trouble.

pgiffuni added 3 commits December 24, 2023 15:49

Merge branch 'apache:trunk' into trunk

6f3a187

Merge branch 'apache:trunk' into trunk

3925d0c

pgiffuni added 3 commits December 26, 2023 13:48

Boost 1.64: small header tidy-ups

a6cf210

Boost 1.64: more headers are future features

574ddc6

Merge branch 'apache:trunk' into trunk

e300484

pgiffuni changed the title ~~Enhance a bit our current boost usage~~ Update boost to version 1.64 Dec 26, 2023

pgiffuni and others added 6 commits December 27, 2023 10:47

Merge branch 'apache:trunk' into trunk

d185bee

Merge branch 'apache:trunk' into trunk

d4b36a2

Merge branch 'apache:trunk' into trunk

9fead39

Merge branch 'apache:trunk' into trunk

3a94f8f

Merge branch 'apache:trunk' into trunk

0aeb288

Update d.lst

20d9a32

Needed for Windows build.

pgiffuni changed the title ~~Update boost to version 1.64~~ Enhance a bit our current boost usage Dec 31, 2023

Pilot-Pirx marked this pull request as draft December 31, 2023 13:42

Merge branch 'apache:trunk' into trunk

686d387

This comment was marked as off-topic.

Sign in to view

pgiffuni and others added 2 commits January 6, 2024 14:06

Merge branch 'apache:trunk' into trunk

10fbae5

Update d.lst

0cc5c2f

Builds fine on Windows now.

Pilot-Pirx marked this pull request as ready for review January 7, 2024 04:56

Pilot-Pirx requested a review from jimjag January 7, 2024 04:56

Pilot-Pirx requested a review from ardovm January 7, 2024 12:41

Merge branch 'apache:trunk' into trunk

ea96d92

Pilot-Pirx merged commit fa664a2 into apache:trunk Jan 14, 2024

Pilot-Pirx mentioned this pull request Jan 14, 2024

Revert "Enhance a bit our current boost usage" #197

Closed

asfgit pushed a commit that referenced this pull request Jan 14, 2024

Revert "Enhance a bit our current boost usage (#194)"

0714fca

This reverts commit fa664a2.

pgiffuni changed the title ~~Enhance a bit our current boost usage~~ Update boost to version 1.64 + minor enhancements Jan 23, 2024

Pilot-Pirx mentioned this pull request Feb 15, 2024

Update boost - Part 1 #202

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update boost to version 1.64 + minor enhancements #194

Update boost to version 1.64 + minor enhancements #194

pgiffuni commented Dec 23, 2023

pgiffuni commented Dec 23, 2023 •

edited

Pilot-Pirx commented Dec 26, 2023

pgiffuni commented Dec 26, 2023

Pilot-Pirx commented Dec 31, 2023

pgiffuni commented Dec 31, 2023 •

edited

Pilot-Pirx commented Dec 31, 2023

pgiffuni commented Dec 31, 2023 •

edited

Pilot-Pirx commented Dec 31, 2023

This comment was marked as off-topic.

Pilot-Pirx commented Jan 7, 2024

Pilot-Pirx commented Jan 7, 2024

pgiffuni commented Jan 13, 2024

Pilot-Pirx commented Jan 13, 2024

pgiffuni commented Jan 14, 2024 •

edited

Pilot-Pirx commented Jan 14, 2024

pgiffuni commented Jan 14, 2024 •

edited

Pilot-Pirx commented Jan 14, 2024

Pilot-Pirx commented Jan 14, 2024

Pilot-Pirx commented Jan 14, 2024 •

edited

pgiffuni commented Jan 23, 2024

Pilot-Pirx commented Feb 5, 2024

Update boost to version 1.64 + minor enhancements #194

Update boost to version 1.64 + minor enhancements #194

Conversation

pgiffuni commented Dec 23, 2023

pgiffuni commented Dec 23, 2023 • edited

Pilot-Pirx commented Dec 26, 2023

Building module sal

pgiffuni commented Dec 26, 2023

Pilot-Pirx commented Dec 31, 2023

pgiffuni commented Dec 31, 2023 • edited

Pilot-Pirx commented Dec 31, 2023

pgiffuni commented Dec 31, 2023 • edited

Pilot-Pirx commented Dec 31, 2023

This comment was marked as off-topic.

Pilot-Pirx commented Jan 7, 2024

Pilot-Pirx commented Jan 7, 2024

pgiffuni commented Jan 13, 2024

Pilot-Pirx commented Jan 13, 2024

pgiffuni commented Jan 14, 2024 • edited

Pilot-Pirx commented Jan 14, 2024

pgiffuni commented Jan 14, 2024 • edited

Pilot-Pirx commented Jan 14, 2024

Pilot-Pirx commented Jan 14, 2024

Pilot-Pirx commented Jan 14, 2024 • edited

pgiffuni commented Jan 23, 2024

Pilot-Pirx commented Feb 5, 2024

pgiffuni commented Dec 23, 2023 •

edited

pgiffuni commented Dec 31, 2023 •

edited

pgiffuni commented Dec 31, 2023 •

edited

pgiffuni commented Jan 14, 2024 •

edited

pgiffuni commented Jan 14, 2024 •

edited

Pilot-Pirx commented Jan 14, 2024 •

edited