Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWB-1135 - Remove duplication for openwebbeans/Messages #5

Closed
wants to merge 1 commit into from
Closed

OWB-1135 - Remove duplication for openwebbeans/Messages #5

wants to merge 1 commit into from

Conversation

danielsoro
Copy link
Member

Created a default factory for OWB Resource Bundle.

@rmannibucau
Copy link
Contributor

Hey @danielsoro, why not using a plain constant instead of creating another abstraction?

@danielsoro
Copy link
Member Author

Hey @rmannibucau yes, your idea sounds better. :)
changing PT in a minute.

@danielsoro
Copy link
Member Author

Hey @rmannibucau, I updated the PR and issue title as well. :)

@danielsoro danielsoro changed the title OWB-1135 - Create ResourceBundleFactory OWB-1135 - Remove duplication for openwebbeans/Messages Jul 3, 2017
@jeanouii
Copy link
Contributor

jeanouii commented Jul 3, 2017

I was about to write the same.
ResourceBundle.getBundle() is by itself a factory method to create a resource bundle. No need to create another one.

Thanks Daniel.

@danielsoro
Copy link
Member Author

Patch applied:
970a1da

@danielsoro danielsoro closed this Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmannibucau rmannibucau rmannibucau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@danielsoro @rmannibucau @jeanouii