Support passing del annotation #488
Conversation
ningyougang
force-pushed
the
support-passing-del-annotation
branch
from
a7c9e83
to
511637b
Compare
ningyougang
force-pushed
the
support-passing-del-annotation
branch
from
511637b
to
3dfd9fe
Compare
|
build error |
| url bool | ||
| save bool | ||
| saveAs string | ||
| delAnnotation []string |
There was a problem hiding this comment.
Add delAnnotation field
|
This is great to finally have!
|
commands/action.go
Outdated
| @@ -1305,6 +1308,7 @@ func init() { | |||
| actionUpdateCmd.Flags().StringVarP(&Flags.common.paramFile, "param-file", "P", "", wski18n.T("`FILE` containing parameter values in JSON format")) | |||
| actionUpdateCmd.Flags().StringVar(&Flags.action.web, WEB_FLAG, "", wski18n.T("treat ACTION as a web action, a raw HTTP web action, or as a standard action; yes | true = web action, raw = raw HTTP web action, no | false = standard action")) | |||
| actionUpdateCmd.Flags().StringVar(&Flags.action.websecure, WEB_SECURE_FLAG, "", wski18n.T("secure the web action. where `SECRET` is true, false, or any string. Only valid when the ACTION is a web action")) | |||
| actionUpdateCmd.Flags().StringArrayVar(&Flags.action.delAnnotation, "del-annotation", []string{}, wski18n.T("del annotation")) | |||
There was a problem hiding this comment.
| actionUpdateCmd.Flags().StringArrayVar(&Flags.action.delAnnotation, "del-annotation", []string{}, wski18n.T("del annotation")) | |
| actionUpdateCmd.Flags().StringArrayVar(&Flags.action.delAnnotation, "del-annotation", []string{}, wski18n.T("the list of annotations to be deleted from the action")) |
There was a problem hiding this comment.
@style95 updated accordingly.
| @@ -480,6 +480,9 @@ func parseAction(cmd *cobra.Command, args []string, update bool) (*whisk.Action, | |||
| return nil, noArtifactError() | |||
| } | |||
|
|
|||
| if update { | |||
| action.DelAnnotations = Flags.action.delAnnotation | |||
There was a problem hiding this comment.
I am not clear about this, can users pass list of annotations? or they have to use --del-annotation for every annotation?
( --del-annotation key1 --del-annotation key2 vs --del-annotation [key1, key2])
There was a problem hiding this comment.
Must pass like this --del-annotation key1 --del-annotation key2, in go backend, it will recevie the value by array:
https://github.com/apache/openwhisk-client-go/pull/137/files#diff-7a2fb893e2fa76731b906c5689a14e95R39
ningyougang
force-pushed
the
support-passing-del-annotation
branch
from
aab03ad
to
0c0070d
Compare
|
The reason of the build failed is that When get the openwhisk-client-go codes, it didn't fetch the latest codes. |
ningyougang
force-pushed
the
support-passing-del-annotation
branch
from
72a76a3
to
30e698a
Compare
- Openwhisk-client-go - pflag
ningyougang
force-pushed
the
support-passing-del-annotation
branch
from
30e698a
to
7a47971
Compare
Currently, if passing another annotations, original previous annotation
will be removed and the passed new annotations will be added.
It may give users some confused that why my previous annotation gone.
So it is better to not delete user's previous annotation when adding new
annotation, but at the same time, need to provide a feature that
support to delete annotation by user via ClI, e.g.
another brother prs to support del annotation: