Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing annotations for rules #165

Closed
shazron opened this issue Apr 23, 2019 · 3 comments · Fixed by #186
Closed

Support passing annotations for rules #165

shazron opened this issue Apr 23, 2019 · 3 comments · Fixed by #186
Milestone
3.20.0

Comments

@shazron
Copy link
Member

shazron commented Apr 23, 2019

Related: apache/openwhisk-cli#426

I inspected the rules code and there doesn't seem to be any code that will pass on annotations.

Looks like ruleBody:
https://github.com/apache/incubator-openwhisk-client-js/blob/e772a2fd0811f4a2c7a0cc4e832c4d08e192b320/lib/rules.js#L35
should accept annotations in the options like actions.js:
https://github.com/apache/incubator-openwhisk-client-js/blob/e772a2fd0811f4a2c7a0cc4e832c4d08e192b320/lib/actions.js#L76
@shazron shazron mentioned this issue Apr 23, 2019
Open
@erezh16
Copy link

erezh16 commented Apr 23, 2019

It seems this issue is focused on the JS client (unlike #426).

  1. Can you please fix the title to reflect that?
  2. I guess this warrants a broader review of this aspect (supporting annotations for rules) in additional client libraries - Python, Go, etc.

@shazron
Copy link
Member Author

shazron commented Apr 23, 2019 •
edited
Loading

  1. The issue is filed in the incubator-openwhisk-client-js repo, so I'm not sure why we need to distinguish further. Seems redundant to me?
  2. This feature is actually needed since wskdeploy does support annotations for rules. See https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/specification/html/spec_shared_entity_schema.md#shared-entity-schema

@jthomas
Copy link
Member

jthomas commented May 7, 2019 •
edited
Loading

@shazron You are right - it looks like the JS SDK has missed this feature. Would you like to open a PR? Looks like you can copy paste the implentation from the actions.js class and associated test cases.

@jthomas jthomas added this to the 3.20.0 milestone Jun 24, 2019
jthomas added a commit to jthomas/openwhisk-client-js that referenced this issue Jul 16, 2019
@jthomas
Add annotation support for rules, triggers and packages.
ecb87f5 
This was missing but looking at the API and CLI should
can be used with the following resources.

Fixes apache#165
jthomas added a commit to jthomas/openwhisk-client-js that referenced this issue Jul 16, 2019
@jthomas
Add annotation support for rules, triggers and packages.
ee95a2c 
This was missing but looking at the API and CLI should
can be used with the following resources.

Fixes apache#165
@jthomas jthomas mentioned this issue Jul 16, 2019
Merged
jthomas added a commit that referenced this issue Jul 16, 2019
@jthomas
Add annotation support for rules, triggers and packages. (#186)
3cd0257 
This was missing but looking at the API and CLI should
can be used with the following resources.

Fixes #165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.20.0
Development

Successfully merging a pull request may close this issue.

Add annotation support for rules, triggers and packages. jthomas/openwhisk-client-js
3 participants
@jthomas @shazron @erezh16