Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow string argument for action get API #105

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Conversation

dubee
Copy link
Member

@dubee dubee commented Mar 14, 2018

Restores original action get API that allows for an action name to be passed to the get method as a string.

@codecov-io
Copy link

codecov-io commented Mar 14, 2018

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          14       14           
  Lines         364      364           
=======================================
  Hits          361      361           
  Misses          3        3
Impacted Files Coverage Δ
lib/actions.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2eb9f5...32ce357. Read the comment docs.

@dubee
Copy link
Member Author

dubee commented Mar 14, 2018

@jthomas, I think this is the fix you wanted. Take a look.

@jthomas jthomas merged commit 3716162 into apache:master Mar 15, 2018
@jthomas
Copy link
Member

jthomas commented Mar 15, 2018

👍 thanks for the quick fix!

@jthomas jthomas mentioned this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants