Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add count to list of valid qs params #109

Merged
merged 4 commits into from
Mar 23, 2018
Merged

add count to list of valid qs params #109

merged 4 commits into from
Mar 23, 2018

Conversation

csantanapr
Copy link
Member

Closes #108

@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          14       14           
  Lines         364      364           
=======================================
  Hits          361      361           
  Misses          3        3
Impacted Files Coverage Δ
lib/rules.js 100% <100%> (ø) ⬆️
lib/triggers.js 100% <100%> (ø) ⬆️
lib/actions.js 100% <100%> (ø) ⬆️
lib/packages.js 100% <100%> (ø) ⬆️
lib/activations.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2542d08...eaabb07. Read the comment docs.

Copy link
Member

@jthomas jthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine but README.md needs updating to document these parameters and unit tests updating with these changes.

@jthomas
Copy link
Member

jthomas commented Mar 23, 2018

Unit tests for all the affected resources have a "should list all X with parameters" test case which needs updating.

README documentation needs updating here: https://github.com/apache/incubator-openwhisk-client-js#list-resources

@csantanapr
Copy link
Member Author

@jthomas I updated README and unit tests

@jthomas jthomas merged commit 0375c28 into master Mar 23, 2018
@csantanapr csantanapr mentioned this pull request Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants