Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating project dependencies & CI/CD scripts #180

Merged
merged 5 commits into from
Jul 8, 2019
Merged

Conversation

jthomas
Copy link
Member

@jthomas jthomas commented Jul 1, 2019

NPM libraries and project setup in package.json hasn't been changed
for a long time....

Reviewing all the existing libraries, removed unnecessary libs and upgraded
all remaining to recent versions (#177). Took the opportunity to refresh the CI/CD
setup. Allowed me to remove lots of old style configuration.

Added a new node_modules size check from #158 & #159

NPM libraries and project setup in package.json hasn't been changed
for a long time....

Reviewing all the existing libraries, removed unnecessary libs and upgraded
all remaining to recent versions (apache#177). Took the opportunity to refresh the CI/CD
setup. Allowed me to remove lots of old style configuration.

Added a new node_modules size check from apache#158 & apache#159
@jthomas jthomas changed the title [WIP] Updating project dependencies & CI/CD scripts Updating project dependencies & CI/CD scripts Jul 5, 2019
@jthomas jthomas removed the wip label Jul 5, 2019
@jthomas
Copy link
Member Author

jthomas commented Jul 5, 2019

This is ready for review. Highlights include....

  • Upgraded all libs to most recent versions, removed lots of unnecessary dev dependencies.
  • Add safety check on node_modules size to CI/CD to stop accidental issues.
  • Re-factored CI/CD setup to be much simpler.

I've got more changes to make before the release but didn't want this PR to get even bigger...

@jthomas jthomas requested a review from rabbah July 5, 2019 15:57
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jthomas jthomas merged commit feb6a88 into apache:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants