Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not modify input params. This closes #230 #231

Merged
merged 2 commits into from
Dec 20, 2021
Merged

fix: Do not modify input params. This closes #230 #231

merged 2 commits into from
Dec 20, 2021

Conversation

purplecabbage
Copy link
Contributor

@purplecabbage purplecabbage commented Dec 15, 2021 •
edited

See #230

rabbah
rabbah approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@rabbah rabbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - is there a test that can be added?

@purplecabbage
Copy link
Contributor Author

@rabbah I added a test that passes, I also made sure the test failed in the previous version.

rabbah
rabbah approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@rabbah rabbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for adding a test.

selfxp
selfxp approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@selfxp selfxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@selfxp selfxp merged commit 3701d0e into apache:master Dec 20, 2021
@shazron shazron mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfxp selfxp selfxp approved these changes

@rabbah rabbah rabbah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@purplecabbage @selfxp @rabbah