Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require at least needle 2.1.0 #90

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Dec 6, 2017

needle 2.1.0 has a fix for the socket hangup issues resulting from needle's erroneous implementation of open timeout

Fixes #89

@jthomas
Copy link
Member

jthomas commented Dec 7, 2017

LGTM 👍

Thanks for finding and resolving this. @starpit if you have merge privs on this repo, feel free to merge and we can get the next version out.

@codecov-io
Copy link

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          14       14           
  Lines         362      362           
=======================================
  Hits          359      359           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132f5b3...3fd6e9f. Read the comment docs.

@rabbah rabbah merged commit c113a98 into apache:master Dec 7, 2017
@jthomas jthomas mentioned this pull request Dec 7, 2017
AnthonyAmanse pushed a commit to AnthonyAmanse/incubator-openwhisk-client-js that referenced this pull request Mar 27, 2019
Fix filename spelling in whiskbot testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

socket hangup issues due to slow connection open
4 participants