Add Code Query Parameter #99
Conversation
dubee
force-pushed
the
code-query
branch
6 times, most recently
from
68695b9
to
81d14bc
Compare
|
@jthomas, I am seeing a trigger failure in Travis. Any idea why that test is failing? |
There was a problem hiding this comment.
Code looks perfect. README needs updating with the new parameter details. Add a sentence or two @ https://github.com/apache/incubator-openwhisk-client-js#retrieve-resource
| @@ -60,7 +79,7 @@ test('should retrieve action from string identifier', t => { | |||
| t.is(path, `namespaces/${ns}/actions/12345`) | |||
| } | |||
|
|
|||
| return actions.get('12345') | |||
There was a problem hiding this comment.
Did you mean to make this change?
There was a problem hiding this comment.
@jthomas, yes this change was needed to prevent an error now that action.get doesn't use the default get method from resources.js.
There was a problem hiding this comment.
@dubeejw The test case was throwing an error because this change broke that API. Can you submit a PR to revert this test case change and modify the get method to handle the string identifier. There's a parse_options method that you can use to handle the string case correctly. https://github.com/apache/incubator-openwhisk-client-js/blob/master/lib/resources.js#L64-L70
We'll push this out as a patch release.
|
Can you re-base this PR once #102 is merged to resolve the build issue? |
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 99.16% 99.17% +<.01%
==========================================
Files 14 14
Lines 361 364 +3
==========================================
+ Hits 358 361 +3
Misses 3 3
Continue to review full report at Codecov.
|
|
@jthomas, Travis is passing for this one now. |
Adds an optional query parameter for action fetches that determines if action code will be retrieved or not.