Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #19: a user can now create a new composition with fine-grained limits #22

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

oEscal
Copy link
Contributor

@oEscal oEscal commented Oct 4, 2023

Made changes so a user can create a new composition with fine-grained limits. For instance, a user can do so with the following commands:

$ <composition> <composition.json> --limits '{"concurrency": 30}'
$ <composition> <composition.json> --limits-file limits.json
# where limits.json has, for instance, the contents '{"logs": 5, "concurrency": 30}'

Moreover, I also did some necessary refactoring to the pydeploy code: fixed the raises (it is necessary to create a BaseException object), created the key_value_arg_verification with duplicated code in the below functions, and used black to prettify the overall code.

…grained limits

Signed-off-by: Pedro Escaleira <pedroescaleira@hotmail.com>
@rabbah
Copy link
Member

rabbah commented Oct 5, 2023

thanks for these patches @oEscal - this PR now has a conflict can you resolve?

@oEscal
Copy link
Contributor Author

oEscal commented Oct 5, 2023

thanks for these patches @oEscal - this PR now has a conflict can you resolve?

Done :)

@rabbah rabbah changed the title Feature #19: a user can now create a new composition with fine-graied limits Feature #19: a user can now create a new composition with fine-grained limits Oct 13, 2023
@rabbah rabbah merged commit 948d299 into apache:master Oct 13, 2023
@oEscal oEscal deleted the feature/composition-limits branch October 13, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants