This repository has been archived by the owner on Aug 16, 2019. It is now read-only.
Adding Ruby v2.5 runtime support #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if there is anything else that needs adding to the PR that I've missed. I think we need to build a docker image for Ruby and publish to https://hub.docker.com/u/projectodd/ |
juliancheal
force-pushed
the
add_ruby_runtime
branch
from
02b3b2b
to
82d4397
Compare
juliancheal
commented
Oct 10, 2018
| @@ -465,28 +474,28 @@ objects: | |||
| value: "${WHISK_KAFKA_REPLICATION_FACTOR}" | |||
| - name: "CONFIG_whisk_kafka_topics_completed_retentionBytes" | |||
| value: "${WHISK_KAFKA_TOPICS_COMPLETED_RETENTION_BYTES}" | |||
|
|
|||
There was a problem hiding this comment.
Not sure why Atom Editor felt the need to change the whitespace.
|
Closing issue to prepare to archive project. Deploying on OpenShift now supported by https://github.com/apache/openwhisk-deploy-kube. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5