Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create fire once action to support firing trigger on a specific date #107

Merged
merged 2 commits into from Nov 13, 2017
Merged

create fire once action to support firing trigger on a specific date #107

merged 2 commits into from Nov 13, 2017

Conversation

jasonpet
Copy link
Contributor

@jasonpet jasonpet commented Nov 10, 2017 •
edited

provides the ability to fire just one trigger on a specified date as mentioned in issue #89 and #102

abaruni
abaruni approved these changes Nov 13, 2017
View reviewed changes
Copy link
Contributor

@abaruni abaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing i think this needs is documentation in the README on the usage. Otherwise, LGTM

@csantanapr csantanapr merged commit 9714585 into apache:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr csantanapr approved these changes

@abaruni abaruni abaruni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasonpet @csantanapr @abaruni