-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow feed to be deleted if trigger does not exist #359
Conversation
console.log(`Trigger auth error: ${JSON.stringify(err)}`); | ||
return Promise.reject({ authError: 'You are not authorized for this trigger.'}); | ||
if (err.statusCode && err.statusCode === 404 && !rejectNotFound) { | ||
return Promise.resolve() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this promise needed or can we do return true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dubee does this affect other openwhisk feed providers? Can you mention this on the dev list 🙏 |
this functionality has always existed for the other providers (Cloudant and Alarms) |
If for some reason a trigger has been deleted though the associated feed still exists, a user cannot delete the corresponding feed manually.