make travis more efficient #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2017 10:06
jasonpet
reviewed
Nov 30, 2017
tools/travis/build.sh
Outdated
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| SCRIPTDIR=$(cd $(dirname "$0") && pwd) | |||
| ROOTDIR="$SCRIPTDIR/../.." | |||
| WHISKDIR="$ROOTDIR/openwhisk" | |||
| WHISKDIR="$ROOTDIR/../openwhisk" | |||
There was a problem hiding this comment.
you need to change the location of where openwhisk is cloned to if you want to make this change. currently this is cloned by the setup.sh that is found in the openwhisk repo. you can create your own setup.sh if you want and clone it to a different location.
jasonpet
reviewed
Nov 30, 2017
.travis.yml
Outdated
| @@ -18,10 +18,7 @@ notifications: | |||
| install: true | |||
|
|
|||
| before_install: | |||
| - 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then openssl aes-256-cbc -K $encrypted_ff5bbb6225c5_key -iv $encrypted_ff5bbb6225c5_iv -in tests/credentials.json.enc -out tests/credentials.json -d; fi' | |||
There was a problem hiding this comment.
why are you removing the encryption. it needs this to get the credentials for the test case.
jasonpet
reviewed
Nov 30, 2017
| @@ -0,0 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
if you are adding jshint validation you need to make sure the current code will pass. based on what I am seeing in my ide it will not
drcariel
force-pushed
the
travisUpdate
branch
from
aef97ad
to
d619f66
Compare
|
@drcariel abandoned PR? Can I close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.