Add test for init twice. (#62)

apache · Jul 6, 2018 · d5caa45 · d5caa45
1 parent 3657b38
commit d5caa45
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 4 deletions.
diff --git a/java8/proxy/src/main/java/openwhisk/java/action/Proxy.java b/java8/proxy/src/main/java/openwhisk/java/action/Proxy.java
@@ -85,10 +85,8 @@ public void handle(HttpExchange t) throws IOException {
                 String base64Jar = message.getAsJsonPrimitive("code").getAsString();
 
                 // FIXME: this is obviously not very useful. The idea is that we
-                // will implement/use
-                // a streaming parser for the incoming JSON object so that we
-                // can stream the contents
-                // of the jar straight to a file.
+                // will implement/use a streaming parser for the incoming JSON object so that we
+                // can stream the contents of the jar straight to a file.
                 InputStream jarIs = new ByteArrayInputStream(base64Jar.getBytes(StandardCharsets.UTF_8));
 
                 // Save the bytes to a file.

diff --git a/tests/src/test/scala/actionContainers/JavaActionContainerTests.scala b/tests/src/test/scala/actionContainers/JavaActionContainerTests.scala
@@ -124,6 +124,34 @@ class JavaActionContainerTests extends FlatSpec with Matchers with WskActorSyste
     err.trim shouldBe empty
   }
 
+  it should "not allow initialization twice" in {
+    val (out, err) = withJavaContainer { c =>
+      val jar = JarBuilder.mkBase64Jar(
+        Seq("example", "HelloWhisk.java") ->
+          """
+            | package example;
+            |
+            | import com.google.gson.JsonObject;
+            |
+            | public class HelloWhisk {
+            |     public static JsonObject main(JsonObject args) {
+            |         return args;
+            |     }
+            | }
+          """.stripMargin.trim)
+
+      val (initCode, _) = c.init(initPayload("example.HelloWhisk", jar))
+      initCode should be(200)
+
+      val (initCode2, out2) = c.init(initPayload("example.HelloWhisk", jar))
+      initCode2 should (be < 200 or be > 299) // the code does not matter, just cannot be 20x
+      out2 should be(Some(JsObject("error" -> JsString("Cannot initialize the action more than once."))))
+    }
+
+    out.trim shouldBe empty
+    err.trim shouldBe empty
+  }
+
   it should "support valid actions with non 'main' names" in {
     val (out, err) = withJavaContainer { c =>
       val jar = JarBuilder.mkBase64Jar(