-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase OW JavaRuntime to use OpenJDK 8 #18
Comments
Can you elaborate more on why this will benefits users that are use to extending the image with a layer by extending |
IMHO since its a redhat sponsored project we try to make the base image on centos - not sure I know any other reason.
If the users want to build their won javaction images then let them do it via FROM with their needed libs, what we give as part of OW java8action is this one which is good to run |
I would preferred to base it on a community based image instead What do you think @Param-S ? We should be able to use this image and add any optimizations to the JVM 8 like Class-Cache and such |
Let's do the image rebase on one PR first. and then build on top of it any other improvements. |
@csantanapr - the reason for using fabric8 images was that it right now works around with the JDK's inability to leverage
I am totally with you on this. I can remove Main class changes from the commit once we decide on base image to use. |
@csantanapr One option to look into would be the AdoptOpenJDK project. It is a OpenSource community effort to have a common build and test framework for OpenJDK across multiple platforms and hopefully in the future across distros as well. Docker images are published on a daily basis on DockerHub. |
@csantanapr - rebased this commit with only OW Docker base image rebase and squashed all commits to one |
@dinogun - does this have jdk8 option ? |
@kameshsampath, yes, it currently supports jdk 8, 9 and 10 builds and the corresponding docker images too. |
since #24 takes care of moving JDK to openjdk we shall close this PR . @csantanapr ??? |
I think you have other changes beyond moving to OpenJDK no? |
yes it does have some auto-classpath settings, some standard directories where the jars are stored and finally the most important one of running as non-root user. I can rebase it once we have #24 merged. WDYT ? |
@csantanapr https://github.com/kameshsampath/adoptopenjdk check that project that has the AdoptOpenJDK based jdk8/jdk9 images for both centos/debian. Wondering if we can move it under OW github repo |
I think this is already done by #24 |
Rebase OW JavaRuntime to fabric8 java image will help us to solve #5 as well making our community runtime image based out of openjdk.
The text was updated successfully, but these errors were encountered: