Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVM heap size is not set correctly for Java actions #5

Open
rabbah opened this issue Nov 18, 2017 · 2 comments
Open

JVM heap size is not set correctly for Java actions #5

rabbah opened this issue Nov 18, 2017 · 2 comments
Labels

Comments

@rabbah
Copy link
Member

rabbah commented Nov 18, 2017

@rabbah commented on Thu Jun 15 2017

Java actions run with no heap settings, regardless of the container's memory limit: https://github.com/apache/incubator-openwhisk/blob/master/core/javaAction/Dockerfile#L38

This will cause a reused Java action to eventually be killed because the GC may not get a chance to run.

>  docker run -m 64M -it javaaction bash
# java -XX:+PrintFlagsFinal -version 2>&1 | grep MaxHeapSize
    uintx MaxHeapSize                              := 1035993088                          {product}

That's ~1GB even though memory limit for container is 64M.


@jsanda commented on Mon Oct 23 2017

Is something like this what you have in mind? run-java.sh is the default command for the image. Among other things it sets the JVM heap size based on container limits.

@rabbah
Copy link
Member Author

rabbah commented Nov 18, 2017

@jsanda thanks for the link; def. looks like what we need.

@andrewnet FYI I moved the issue here where it is best addressed.

@sven-lange-last
Copy link
Member

Addressed by #95. Also see #77

Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants