Skip to content

Commit

Permalink
remove Node.js 12 based runtime (EOL April 30, 2022) (#218)
Browse files Browse the repository at this point in the history
  • Loading branch information
dgrove-oss committed May 13, 2022
1 parent 339bc7b commit fff64bc
Show file tree
Hide file tree
Showing 12 changed files with 3 additions and 332 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ deploy:
all_branches: true
repo: apache/openwhisk-runtime-nodejs
- provider: script
script: "./tools/travis/publish.sh openwhisk nodejs12Action nightly && ./tools/travis/publish.sh openwhisk nodejs14Action nightly && ./tools/travis/publish.sh openwhisk nodejs16Action nightly && ./tools/travis/publish.sh openwhisk typescript37Action nightly"
script: "./tools/travis/publish.sh openwhisk nodejs14Action nightly && ./tools/travis/publish.sh openwhisk nodejs16Action nightly && ./tools/travis/publish.sh openwhisk typescript37Action nightly"
on:
branch: master
repo: apache/openwhisk-runtime-nodejs
Expand Down
14 changes: 2 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ This repository contains sources files needed to build the Node.js runtimes for

The following Node.js runtime versions (with kind & image labels) are generated by the build system:

- Node.js 12.22.2 (`nodejs:12` & `openwhisk/action-nodejs-v12`)
- Node.js 14.17.2 (`nodejs:14` & `openwhisk/action-nodejs-v14`)
- Node.js 16.13.1 (`nodejs:16` & `openwhisk/action-nodejs-v16`)

Expand All @@ -38,12 +37,6 @@ This README documents the build, customisation and testing of these runtime imag

If the deployment of Apache OpenWhisk includes these images in the runtime manifest, use the `--kind` parameter to select the Node.js runtime version.

### Node.js v12

```
wsk action update myAction myAction.js --kind nodejs:12
```

### Node.js v14

```
Expand All @@ -60,14 +53,13 @@ wsk action update myAction myAction.js --kind nodejs:16

All the runtime images are published by the project to Docker Hub @ [https://hub.docker.com/u/openwhisk](https://hub.docker.com/u/openwhisk)

- [https://hub.docker.com/r/openwhisk/action-nodejs-v12](https://hub.docker.com/r/openwhisk/action-nodejs-v12)
- [https://hub.docker.com/r/openwhisk/action-nodejs-v14](https://hub.docker.com/r/openwhisk/action-nodejs-v14)
- [https://hub.docker.com/r/openwhisk/action-nodejs-v16](https://hub.docker.com/r/openwhisk/action-nodejs-v16)

These images can be used to execute Node.js actions on any deployment of Apache OpenWhisk, even those without those images defined the in runtime manifest, using the `--docker` action parameter.

```
wsk action update myAction myAction.js --docker openwhisk/action-nodejs-v12
wsk action update myAction myAction.js --docker openwhisk/action-nodejs-v16
```

If you build a custom version of the images, pushing those an external Docker Hub repository will allow you to use those on the Apache OpenWhisk deployment.
Expand All @@ -89,12 +81,11 @@ The `core/nodejsActionBase` folder contains the Node.js app server used to imple
- Run the `distDocker` command to generate local Docker images for the different runtime versions.

```
./gradlew core:nodejs12Action:distDocker
./gradlew core:nodejs14Action:distDocker
./gradlew core:nodejs16Action:distDocker
```

This will return the following runtime images with the following names: `action-nodejs-v12`, `action-nodejs-v14` and `action-nodejs-v16`.
This will return the following runtime images with the following names: `action-nodejs-v14` and `action-nodejs-v16`.

### Testing

Expand All @@ -110,7 +101,6 @@ This will return the following runtime images with the following names: `action-
- Build the custom Docker images used in local testing.

```
./gradlew tests:dat:docker:nodejs12docker:distDocker
./gradlew tests:dat:docker:nodejs14docker:distDocker
./gradlew tests:dat:docker:nodejs16docker:distDocker
```
Expand Down
13 changes: 0 additions & 13 deletions core/nodejs12Action/.dockerignore

This file was deleted.

75 changes: 0 additions & 75 deletions core/nodejs12Action/CHANGELOG.md

This file was deleted.

43 changes: 0 additions & 43 deletions core/nodejs12Action/Dockerfile

This file was deleted.

86 changes: 0 additions & 86 deletions core/nodejs12Action/build.gradle

This file was deleted.

2 changes: 0 additions & 2 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,9 @@
include 'tests'

include 'core:nodejsActionBase'
include 'core:nodejs12Action'
include 'core:nodejs14Action'
include 'core:nodejs16Action'
include 'core:typescript37Action'
include 'tests:dat:docker:nodejs12docker'
include 'tests:dat:docker:nodejs14docker'
include 'tests:dat:docker:nodejs16docker'
include 'tests:dat:docker:typescript37docker'
Expand Down
19 changes: 0 additions & 19 deletions tests/dat/docker/nodejs12docker/Dockerfile

This file was deleted.

19 changes: 0 additions & 19 deletions tests/dat/docker/nodejs12docker/build.gradle

This file was deleted.

8 changes: 0 additions & 8 deletions tests/dat/docker/nodejs12docker/package.json

This file was deleted.

This file was deleted.

Loading

0 comments on commit fff64bc

Please sign in to comment.