Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use import instead of compile for build.gradle as 6 is now beeing used #73

Merged
merged 4 commits into from Aug 4, 2022

Conversation

Luke-Roy-IBM
Copy link
Member

No description provided.

Copy link
Member

@upgle upgle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@upgle
Copy link
Member

upgle commented Aug 3, 2022

@Luke-Roy-IBM Please add the dependencies as well. The core project uses implementation instead of compile as well, so it no longer shares dependencies with sub project.

 }
 dependencies {
+    implementation "junit:junit:4.11"
     implementation "org.scala-lang:scala-library:${gradle.scala.version}"
+    implementation "org.scalatest:scalatest_${gradle.scala.depVersion}:3.0.8"
+    implementation "org.apache.openwhisk:openwhisk-common:${gradle.openwhisk.version}"
     implementation "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
     implementation "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
     implementation group: 'com.typesafe.akka', name: "akka-http2-support_${gradle.scala.depVersion}", version: "${gradle.akka_http.version}"

@ningyougang ningyougang merged commit 7c17e4c into apache:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants