Various fixes for swift 4 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @jthomas |
dubee
requested changes
Feb 4, 2018
| val (initCode, initRes) = c.init(initPayload(code)) | ||
| initCode should be(200) | ||
|
|
||
| val arg = JsObject("arg" -> JsString(("a" * 198144))) |
There was a problem hiding this comment.
Hmm, double check that this is actually a MB.
There was a problem hiding this comment.
Looks likes the highest I can go without an margin of error is 1048561 will update test
tests/dat/build.sh
Outdated
| @@ -6,4 +6,6 @@ set -e | |||
|
|
|||
| ../../tools/build/compile.sh HelloSwift4 swift:4 "-v" | |||
|
|
|||
| ../../tools/build/compile.sh SwiftyRequest swift:4 "-v" | |||
|
|
|||
|
@dubeejw take a look now |
dubee
approved these changes
Feb 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16 with urlSesson double free or corruption
Fixes #14 with large paramters