Update Usage for Activation Poll #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdeuser, please review. |
mdeuser
requested changes
Jun 20, 2017
| @@ -217,8 +217,8 @@ var activationResultCmd = &cobra.Command{ | |||
| } | |||
|
|
|||
| var activationPollCmd = &cobra.Command{ | |||
| Use: "poll [NAMESPACE]", | |||
| Short: wski18n.T("poll continuously for log messages from currently running actions"), | |||
| Use: "poll [ NAMESPACE | ENTITY_NAME ]", | |||
There was a problem hiding this comment.
since the list is limited, i think the more explicit poll [NAMESPACE | ACTION_NAME | TRIGGER_NAME | RULE_NAME] is helpful
|
new syntax LGTM |
mdeuser
approved these changes
Jun 20, 2017
| @@ -217,8 +217,8 @@ var activationResultCmd = &cobra.Command{ | |||
| } | |||
|
|
|||
| var activationPollCmd = &cobra.Command{ | |||
| Use: "poll [NAMESPACE]", | |||
| Short: wski18n.T("poll continuously for log messages from currently running actions"), | |||
| Use: "poll [ NAMESPACE | ACTION_NAME | TRIGGER_NAME | RULE_NAME ]", | |||
|
@bjustin-ibm, can you merge this one too? |
jberstler
approved these changes
Jun 23, 2017
jonpspri
pushed a commit
to jonpspri/openwhisk
that referenced
this pull request
Jul 4, 2017
* Update Usage for Activation Poll
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Jul 10, 2017
* Update Usage for Activation Poll
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Jul 21, 2017
* Update Usage for Activation Poll
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
* Update Usage for Activation Poll
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
* Update Usage for Activation Poll
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 14, 2017
* Update Usage for Activation Poll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Activation Poll usage inform users that an entity name (action, trigger, or rule) can be provided as an optional argument.
Closes: #2273