Use error message const to avoid replication. #2502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbah
reviewed
Jul 18, 2017
|
As @rabbah (I believe) is indicating... and specifically the translated map: |
|
Specifically the id in the translation file should be a well known constant, like |
|
Seems doesn't work like that, @mdeuser , could you please help take a review? |
tools/cli/go-whisk/whisk/wskerror.go
Outdated
| @@ -34,6 +34,7 @@ const NO_DISPLAY_PREFIX bool = false | |||
| const APPLICATION_ERR bool = true | |||
| const NO_APPLICATION_ERR bool = false | |||
| const TIMED_OUT bool = true | |||
| const UNABLE_CREATE_ACTION_ERR string = "Unable to create action '{{.name}}': {{.err}}" | |||
There was a problem hiding this comment.
This needs to be
const UNABLE_CREATE_ACTION_ERR string = "UNABLE_CREATE_ACTION_ERR"to work.
There was a problem hiding this comment.
Ok, thank you for your help @markusthoemmes , seems I don't t get the real spirit of of the issue yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed before.. If we agree this is correct, I'll continue the remain ones.