New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vagrant base image update to latest Ubuntu Xenial LTS #2891
Conversation
- was 2.11.6, updated to 2.11.11
…s accordingly - The version of Ubuntu being used was 14.04 (Trusty) which is EOL and 3+ years old - Updated to 16.04, Xenial, which is most current LTS - Moved from Ubuntu images to Chef Bento – Ubuntu's images after 14.04 started breaking Vagrant convention by not creating a "vagrant" user. Chef Bento images keep with Vagrant convention and obviate the need for extra "create user" scripts - Updated Ubuntu Tools Docker image accordingly
I was getting the same error as @akrabat in his gist at https://gist.github.com/akrabat/bc0bcbfd78c4f78686bac1fbc41e3054 and unable to start the Vagrant image locally. The changes in this PR fixed that error and the image now provisions successfully. |
As @bbrowning has noted, the current Vagrant box does not successfully provision. I've tested this PR and it works. |
Can we make a new set of instructions for Xenial, maybe under I'm OK if the Vagrant scenario uses Xenial, I'm just worried about people using the current setup in ubuntu 14 and using the current scripts under Also scala is currently configured for |
|
||
# DOCKER | ||
sudo apt-get install -y --force-yes docker-engine=1.12.0-0~trusty | ||
sudo apt-get install -y --force-yes docker-ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to install docker 1.12 if possible since it's the version we support
tools/ubuntu-setup/docker.sh
Outdated
|
||
# enable (security - use 127.0.0.1) | ||
sudo -E bash -c 'echo '\''DOCKER_OPTS="-H tcp://0.0.0.0:4243 -H unix:///var/run/docker.sock --storage-driver=aufs"'\'' >> /etc/default/docker' | ||
#sudo -E bash -c 'echo '\''DOCKER_OPTS="-H tcp://0.0.0.0:4243 -H unix:///var/run/docker.sock --storage-driver=aufs"'\'' >> /etc/default/docker' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving commented code is kind ugly either remove it or leave it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch; fixing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually suspect I shouldn't have commented these out; testing with them reenabled otherwise will remove.
wget www.scala-lang.org/files/archive/scala-2.11.6.deb -O /tmp/scala-2.11.6.deb | ||
sudo dpkg -i /tmp/scala-2.11.6.deb | ||
#wget www.scala-lang.org/files/archive/scala-2.11.6.deb -O /tmp/scala-2.11.6.deb | ||
wget https://downloads.lightbend.com/scala/2.11.11/scala-2.11.11.deb -O /tmp/scala-2.11.11.deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2.11.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? We're effectively on 2.11.11.
@bwmcadams Can you try to throw out Scala compiler installation? Gradle should handle that for us anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Note this includes the REPL as well, but I don't think people should be doing REPL debugging on their host machine(s) anyway.
EDIT: Just recalled I commented these because the updated VM was giving me issues with them, and the updated instructions for setting up docker no longer included them. Will remove.
@csantanapr Ah, for some reason I thought I saw 2.11.11 used in a bunch of places. We should update that to latest 2.11.x series, but that seems like a separate set of PRs to me. |
@csantanapr I am fine with splitting things off into Xenial subfolder, but I'd suggest if we are going to do that we also create a sep. one for 14. If we leave a "default" folder without clear versioning info it may lead to more confusion. The current folder would become a parent with just a short README explaining the subfolders/versioning. Thoughts? |
@bwmcadams
|
Then why do we have |
breaking Vagrant convention by not creating a "vagrant" user. Chef Bento images
keep with Vagrant convention and obviate the need for extra "create user" scripts