Increase max-content-length to 50 MB #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4059 +/- ##
==========================================
- Coverage 86.07% 81.16% -4.91%
==========================================
Files 147 147
Lines 7173 7173
Branches 449 449
==========================================
- Hits 6174 5822 -352
- Misses 999 1351 +352
Continue to review full report at Codecov.
|
dubee
reviewed
Oct 8, 2018
| @@ -349,6 +349,10 @@ public static boolean onLinux() { | |||
| return osname.equalsIgnoreCase("linux"); | |||
| } | |||
|
|
|||
| public static int getMaxActionSizeMB(){ | |||
| return Integer.parseInt(getProperty("whisk.action.size.max", "10")); | |||
There was a problem hiding this comment.
@chetanmeh, where is whisk.action.size.max set?
There was a problem hiding this comment.
Currently its not set and hence defaults to 10 MB. I wish to configure this (via system property) when we run system basic test against out setup with the max value that the cluster supports.
|
@dubee @markusthoemmes Please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current setup reading code attachment more than 8 MB results in error (#4028). Increase
max-content-lengthto 50 MB allows reading code attachments upto maximum allowed 48 MBDescription
Akka uses max-content-length to ensure limits on incoming request entities. By default it is 8 MB while OpenWhisk allows max code upto 48 MB. To enable such large action code as attachment increase the max-content-length to 50 MB
Basic Test
This PR also adds a system basic test to ensure that such large actions can be created. Due to constrained resource on travis test only create action code upto 10 MB. However it can be increased via config by setting system property
whisk.action.size.max(in MB)This test would also help to validate if the proxy and other settings are properly configured. See #3712 for details on which all settings need to be configured
Related issue and scope
My changes affect the following components
Types of changes
Checklist: