Always return activation without log on blocking invoke.

[cbickel]

If an user invokes an action blockingly today, the invoker executes the activation and sends back the result to the controller, which passes it back to the client. If it is not possible to pass the result back to the controller, it will try to get it from the database. And here's the problem. If the controller receives the result of the activation from the invoker, there are no logs included. If it polls it from the database, the logs are included. This should be unified to never return logs.

Related issue and scope

• I opened an issue to propose and discuss this change (#????)

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• I signed an Apache CLA.
• I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[markusthoemmes]

Makes sense and LGTM 👍

[codecov-io]

Codecov Report

Merging #4100 into master will increase coverage by 4.59%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4100      +/-   ##
==========================================
+ Coverage   76.63%   81.22%   +4.59%     
==========================================
  Files         148      148              
  Lines        7249     7249              
  Branches      445      442       -3     
==========================================
+ Hits         5555     5888     +333     
+ Misses       1694     1361     -333

Impacted Files	Coverage Δ
...isk/core/controller/actions/PrimitiveActions.scala	87.5% <100%> (+2.08%)	⬆️
...core/database/cosmosdb/RxObservableImplicits.scala	0% <0%> (-100%)	⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala	0% <0%> (-95.54%)	⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala	0% <0%> (-92.6%)	⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala	0% <0%> (-83.34%)	⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala	0% <0%> (-58.83%)	⬇️
...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala	92% <0%> (-4%)	⬇️
...r/src/main/scala/whisk/core/controller/Rules.scala	89.93% <0%> (+0.67%)	⬆️
...src/main/scala/whisk/core/controller/Actions.scala	93.03% <0%> (+1.49%)	⬆️
.../containerpool/ApacheBlockingContainerClient.scala	72.72% <0%> (+1.81%)	⬆️
... and 42 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47410d...a6e71b5. Read the comment docs.

[rabbah]

LGTM also - I thought we used to do this in the Actions API route but must have lost it in some refactoring. Good catch.