Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ballerina 0.990.2 runtime. #4239

Merged
merged 2 commits into from
Jan 26, 2019
Merged

Add Ballerina 0.990.2 runtime. #4239

merged 2 commits into from
Jan 26, 2019

Conversation

rabbah
Copy link
Member

@rabbah rabbah commented Jan 26, 2019

See relevant issue.

Description

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@rabbah rabbah added enhancement runtime review Review for this PR has been requested and yet needs to be done. labels Jan 26, 2019
],
"ballerina": [
{
"kind": "ballerina:0.990.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to be this specific “0.990.2” with the version ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ballerina:0.9 ? From user perspective do they need to worry about their action not working with 0.xxx.y updates ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will drop the patch from the kind.

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #4239 into master will decrease coverage by 4.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4239      +/-   ##
==========================================
- Coverage   85.96%   81.24%   -4.73%     
==========================================
  Files         156      156              
  Lines        7415     7415              
  Branches      480      480              
==========================================
- Hits         6374     6024     -350     
- Misses       1041     1391     +350
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-95.6%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-92.6%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-83.34%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 4.54% <0%> (-45.46%) ⬇️
...in/scala/org/apache/openwhisk/common/Counter.scala 40% <0%> (-20%) ⬇️
...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala 93.75% <0%> (-6.25%) ⬇️
...whisk/connector/kafka/KafkaProducerConnector.scala 87.5% <0%> (+15%) ⬆️
.../scala/org/apache/openwhisk/utils/Exceptions.scala 40% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6f6a7...5ba2e63. Read the comment docs.

@rabbah rabbah merged commit 12f121e into apache:master Jan 26, 2019
@rabbah rabbah deleted the balx branch February 8, 2019 02:27
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement review Review for this PR has been requested and yet needs to be done. runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants