Make ContainerProxyTests more stable.

[cbickel]

As the active ack is sent asynchronously in the invoker, it could happen, that the order of them is wrong in the ContainerProxyTest. This has been proven with the following debug information: #4278

This PR makes these tests more stable by not relying on the order of active acks.

Related issue and scope

• I opened an issue to propose and discuss this change (#????)

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• I signed an Apache CLA.
• I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[markusthoemmes]

Nice find, minor nit on saving some line sand boilerplate.

[markusthoemmes]

As you already know that the size is 2 and you need both calls, could this be:

val (initRunActivation, runOnlyActivation) = {
  // false is sorted before true
  val sorted = acker.calls.sortBy(_._2.annotations.get(WhiskActivation.initTimeAnnotation).isEmpty)
  sorted(0)._2, sorted(1)._2
}

[cbickel]

That's a good point. 👍

[markusthoemmes]

Another nit for places where you only need one instance (didn't realize that's needed sorry)

[markusthoemmes]

For the instances where you only need one of the calls:

val initRunActivation = acker.calls.find(_._2.annotations.get(WhiskActivation.initTimeAnnotation).isDefined).getOrElse(fail("..."))

?

[cbickel]

This would keep consistency to the other tests that I've adapted, but then we need another check to verify that only one of the activations contains the init annotation.
So personally I'd prefer to use filter, checking the size of the result and using head.

[markusthoemmes]

Alrighty then! Nice fix! 🙂

[chetanmeh]

Saw another set of failure related to ContainerProxy https://scans.gradle.com/s/36yxkcjvgad6y/tests/failed

[cbickel]

@chetanmeh Thanks for the hint. But on the first view it looks to me, like there is a completely different root cause, compared to the problem that has been fixed here.