Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CosmosDB to 2.4.2 #4321

Merged
merged 3 commits into from
Mar 5, 2019
Merged

Conversation

chetanmeh
Copy link
Member

@chetanmeh chetanmeh commented Mar 4, 2019

Updates CosmosDB to 2.4.2 (from 2.4.0) as it has some fixes related to cross partition queries

Description

Couple of changes in this PR

  1. Update to CosmosDB SDK 2.4.2
  2. Removes support for storing attachment in ComsosDB and requires an external AttachmentStore to be configured. (Fixes Storing attachments in CosmosDB fails with v2.4.0 #4286)
  3. Reduces the configured throughput for test runs to 400 from current 1000. Would save some money!

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@chetanmeh chetanmeh added the cosmosdb Issues related to CosmosDB support label Mar 4, 2019
@codecov-io
Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #4321 into master will decrease coverage by 4.32%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4321      +/-   ##
==========================================
- Coverage   85.71%   81.39%   -4.33%     
==========================================
  Files         168      168              
  Lines        7870     7814      -56     
  Branches      524      520       -4     
==========================================
- Hits         6746     6360     -386     
- Misses       1124     1454     +330
Impacted Files Coverage Δ
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-95.11%) ⬇️
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-92.6%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-84.62%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 4% <0%> (-52%) ⬇️
...in/scala/org/apache/openwhisk/common/Counter.scala 40% <0%> (-20%) ⬇️
.../scala/org/apache/openwhisk/utils/Exceptions.scala 20% <0%> (-20%) ⬇️
...whisk/connector/kafka/KafkaProducerConnector.scala 72.5% <0%> (-15%) ⬇️
...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala 94.11% <0%> (-5.89%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b28f46...84ec6a8. Read the comment docs.

@chetanmeh
Copy link
Member Author

Travis build for branch passed which has CosmosDB test enabled

Copy link
Contributor

@tysonnorris tysonnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@tysonnorris tysonnorris merged commit 1c3de9f into apache:master Mar 5, 2019
@chetanmeh chetanmeh deleted the cosmosdb-2.4.2 branch March 5, 2019 06:01
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
* Update to CosmosDB SDK 2.4.2

* Remove logic related to storing attachments in CosmosDB

* Reduce throughput for test to 400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmosdb Issues related to CosmosDB support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storing attachments in CosmosDB fails with v2.4.0
3 participants