Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume mapping for Docker credentials #4791

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

style95
Copy link
Member

@style95 style95 commented Jan 7, 2020

Fix #4787

Additional information you deem important:

An operator can make invokers access to a private registry by adding this:

invoker_docker_volumes:
  - ~/.docker:/root/.docker

@style95 style95 added the wip label Jan 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #4791 into master will decrease coverage by 6.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4791      +/-   ##
==========================================
- Coverage   85.18%   78.53%   -6.65%     
==========================================
  Files         197      197              
  Lines        8843     8843              
  Branches      610      610              
==========================================
- Hits         7533     6945     -588     
- Misses       1310     1898     +588
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...n/scala/org/apache/openwhisk/common/CausedBy.scala 0% <0%> (-100%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0% <0%> (-100%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0% <0%> (-100%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-96.23%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-93.85%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0% <0%> (-92.31%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0% <0%> (-77.78%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-74.08%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7b6ec...6d11ccf. Read the comment docs.

@style95 style95 removed the wip label Jan 7, 2020
@style95
Copy link
Member Author

style95 commented Jan 7, 2020

It's ready to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow different Docker Repos and Credentials to pull Docker Images
3 participants