Allow to get activation list by a binding package name #4919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgle
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4919 +/- ##
==========================================
- Coverage 83.51% 77.72% -5.80%
==========================================
Files 201 201
Lines 9441 9521 +80
Branches 396 407 +11
==========================================
- Hits 7885 7400 -485
- Misses 1556 2121 +565
Continue to review full report at Codecov.
|
jiangpengcheng
approved these changes
Jun 13, 2020
|
|
style95
approved these changes
Jun 14, 2020
rabbah
reviewed
Jun 15, 2020
| @@ -3,7 +3,7 @@ | |||
| "language": "javascript", | |||
| "views": { | |||
| "activations": { | |||
| "map": "function (doc) {\n var PATHSEP = \"/\";\n var isActivation = function (doc) { return (doc.activationId !== undefined) };\n var summarize = function (doc) {\n var endtime = doc.end !== 0 ? doc.end : undefined;\n return {\n namespace: doc.namespace,\n name: doc.name,\n version: doc.version,\n publish: doc.publish,\n annotations: doc.annotations,\n activationId: doc.activationId,\n start: doc.start,\n end: endtime,\n duration: endtime !== undefined ? endtime - doc.start : undefined,\n cause: doc.cause,\n statusCode: (endtime !== undefined && doc.response !== undefined && doc.response.statusCode !== undefined) ? doc.response.statusCode : undefined\n }\n };\n\n var pathFilter = function(doc) {\n for (i = 0; i < doc.annotations.length; i++) {\n var a = doc.annotations[i];\n if (a.key == \"path\") try {\n var p = a.value.split(PATHSEP);\n if (p.length == 3) {\n return p[1] + PATHSEP + doc.name;\n } else return doc.name;\n } catch (e) {\n return doc.name;\n }\n }\n return doc.name;\n }\n\n if (isActivation(doc)) try {\n var value = summarize(doc)\n emit([doc.namespace+PATHSEP+pathFilter(doc), doc.start], value);\n } catch (e) {}\n}\n", | |||
| "map": "function (doc) {\n var PATHSEP = \"/\";\n var isActivation = function (doc) { return (doc.activationId !== undefined) };\n var summarize = function (doc) {\n var endtime = doc.end !== 0 ? doc.end : undefined;\n return {\n namespace: doc.namespace,\n name: doc.name,\n version: doc.version,\n publish: doc.publish,\n annotations: doc.annotations,\n activationId: doc.activationId,\n start: doc.start,\n end: endtime,\n duration: endtime !== undefined ? endtime - doc.start : undefined,\n cause: doc.cause,\n statusCode: (endtime !== undefined && doc.response !== undefined && doc.response.statusCode !== undefined) ? doc.response.statusCode : undefined\n }\n };\n \n var pathFilter = function(doc) {\n var path = undefined;\n var binding = undefined;\n for (i = 0; i < doc.annotations.length; i++) {\n var a = doc.annotations[i];\n if (a.key == \"path\") {\n path = a.value;\n }\n if (a.key == \"binding\") {\n binding = a.value;\n }\n }\n try {\n if (binding) {\n var b = binding.split(PATHSEP)\n return b[1] + PATHSEP + doc.name;\n }\n if (path) {\n var p = path.split(PATHSEP);\n if (p.length == 3) {\n return p[1] + PATHSEP + doc.name;\n } else return doc.name; \n }\n } catch (e) {\n return doc.name;\n }\n return doc.name;\n }\n\n if (isActivation(doc)) try {\n var value = summarize(doc)\n emit([doc.namespace+PATHSEP+pathFilter(doc), doc.start], value);\n } catch (e) {}\n}\n", | |||
There was a problem hiding this comment.
please use a new view with a different version number since updating this design doc will cause the view to recompute which can take a long time.
rabbah
reviewed
Jun 30, 2020
|
@rabbah Thank you for your review. I've added the v2.1.0 view again. |
|
I am merging this with the confirmation from @rabbah again on Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users cannot query the activation list by a binding package name. And It also becomes ambiguous if there is a package that is the same as the original package name of the binding package.
This PR changes the activation list query to more clear.
Ambiguous case
In this case, the
guestnamespace cannot get the activations invoked only in the/guest/p1package.The entity name
/whisk.system/p1/a1and/guest/p1/a1returns same results:User expected behavior for activations of binding package action
In general, the behavior expected by the user is to get activations for each binding package. They expect to see activations of the two binding packages separately.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: