Add ability to scale Ephemeral storage along with memory, similar to CPU #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfxp
reviewed
Oct 21, 2020
| @@ -108,7 +108,12 @@ class WhiskPodBuilder(client: NamespacedKubernetesClient, config: KubernetesClie | |||
| .getOrElse(Map.empty) | |||
|
|
|||
| val diskLimit = config.ephemeralStorage | |||
| .map(diskConfig => Map("ephemeral-storage" -> new Quantity(diskConfig.limit.toMB + "Mi"))) | |||
| .map(diskConfig => | |||
| if (diskConfig.scaleFactor > 0) { | |||
There was a problem hiding this comment.
Can diskConfig.scaleFactor be null?
There was a problem hiding this comment.
Didn't think null was a valid value for a Double but, maybe I'm mixing up languages. Will test thanks!
There was a problem hiding this comment.
based on KubernetesEphemeralStorageConfigsig it should not be null, but technically it might be possible; If null was allowed, it should be Option[Doube]; I would leave it as is
dgrove-oss
approved these changes
Oct 21, 2020
tysonnorris
reviewed
Oct 21, 2020
| .map(diskConfig => Map("ephemeral-storage" -> new Quantity(diskConfig.limit.toMB + "Mi"))) | ||
| .map(diskConfig => | ||
| if (diskConfig.scaleFactor > 0) { | ||
| Map("ephemeral-storage" -> new Quantity(diskConfig.scaleFactor * memory.toMB + "Mi")) |
There was a problem hiding this comment.
I think there should still be a limit - i.e. use the scale factor unless the result is > some limit.
There was a problem hiding this comment.
That's a fair critique. Will do that and adjust the docs.
style95
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on setting a simple limit for k8s ephemeral storage this introduces another config setting to also allow scaling the storage based on the memory.
Description
Along with CPU it seems reasonable action developers may need more disk as their actions use more and more memory. Ideally, we'd start to tease all this apart to allow developers to request a variety of resources but this simply creates a similar setting as CPU to allow the disk capacity to stretch along with memory.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: