Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runtime delete timeout configurable #5028

Merged

Conversation

ningyougang
Copy link
Contributor

@ningyougang ningyougang commented Nov 18, 2020

Description

In kubenetes env, if runtime pod number is big and akka.coordinated-shutdown.phases.actor-system-terminate_timeout is low(e.g default value is 30 s), this may lead to the runtime pods are not deleted completely after execute helm delete/uninstall xxx, because when timeout happens, the cleanup is not executed finished.

In such a case, need to increase relative timeout value, it is better to make these timeout value configurable.

Another brother pr: apache/openwhisk-deploy-kube#653

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ningyougang ningyougang force-pushed the make-runtime-delete-timeout-configurable branch from 484d44b to c9b3445 Compare November 19, 2020 06:13
Copy link
Contributor

@jiangpengcheng jiangpengcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ningyougang ningyougang reopened this Nov 20, 2020
@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #5028 (c9b3445) into master (526f011) will decrease coverage by 6.96%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5028      +/-   ##
==========================================
- Coverage   83.85%   76.88%   -6.97%     
==========================================
  Files         202      202              
  Lines        9817     9818       +1     
  Branches      415      416       +1     
==========================================
- Hits         8232     7549     -683     
- Misses       1585     2269     +684     
Impacted Files Coverage Δ
...erpool/kubernetes/KubernetesContainerFactory.scala 0.00% <0.00%> (ø)
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0.00% <0.00%> (-78.58%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0.00% <0.00%> (-74.08%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 526f011...c9b3445. Read the comment docs.

@rabbah rabbah merged commit 4babe39 into apache:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants