New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Scheduler] Manage container creation #5074
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5074 +/- ##
==========================================
- Coverage 81.25% 75.17% -6.08%
==========================================
Files 218 222 +4
Lines 10700 11010 +310
Branches 450 484 +34
==========================================
- Hits 8694 8277 -417
- Misses 2006 2733 +727
Continue to review full report at Codecov.
|
The standalone test continues to fail because an error occurred while pulling
|
I worked around this by pulling such kind images in advance before starting tests. |
result = prime * result + tags.hashCode() | ||
result = prime * result + dedicatedNamespaces.hashCode() | ||
result | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ansible/group_vars/all
Outdated
@@ -139,6 +139,7 @@ registry: | |||
confdir: "{{ config_root_dir }}/registry" | |||
|
|||
kafka: | |||
topicsPrefix: "{{ kafka_topics_prefix | default('') }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add prefix for kafka topic
feature is already implemented in this pr: #5062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@KeonHee
Can we add some design documents for this component especially regarding the container creation/deletion process and warmup process here?
https://cwiki.apache.org/confluence/display/OPENWHISK/Component+Design
@style95 Sure. I will upload it ASAP |
I wrote a document: https://cwiki.apache.org/confluence/display/OPENWHISK/ContainerManager |
Can we add a section about warmup? |
Codecov Report
@@ Coverage Diff @@
## master #5074 +/- ##
==========================================
- Coverage 81.11% 75.54% -5.57%
==========================================
Files 214 225 +11
Lines 10913 11423 +510
Branches 469 501 +32
==========================================
- Hits 8852 8630 -222
- Misses 2061 2793 +732
Continue to review full report at Codecov.
|
Description
My changes affect the following components
Types of changes
Checklist: