Disable StandaloneKCFTests #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only test case being run (invoke a blocking action and get a result) fails quite frequently when run in a travis-ci environment. It appears we usually hit the 60 second timeout and return a 202 with the activation id instead of the expected result. This is "ok", but the test is not prepared to handle it. An alternative would be to modify the test to also accept a 202 response and then poll until the result was available, but that would take significantly more work.
Codecov Report
@@ Coverage Diff @@
## master #5140 +/- ##
===========================================
+ Coverage 43.96% 74.59% +30.62%
===========================================
Files 231 231
Lines 12807 12807
Branches 528 528
===========================================
+ Hits 5631 9553 +3922
+ Misses 7176 3254 -3922
Continue to review full report at Codecov.
|
|
@dgrove-oss I'll merge this and can take a look at the standalone test to adjust it as you describe. |
rabbah
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only test case being run (invoke a blocking action
and get a result) fails quite frequently when run in
a travis-ci environment. It appears we usually hit the
60 second timeout and return a 202 with the activation id
instead of the expected result. This is "ok", but the test
is not prepared to handle it.
An alternative would be to modify the test to also accept a 202
response and then poll until the result was available, but that
would take significantly more work.