Add ws and socket.io-client packages to the Node.js runtime #523
Conversation
|
@markusthoemmes based on the history of the |
|
@bjustin-ibm need to update refrences.md |
jberstler
force-pushed
the
wspackages
branch
2 times, most recently
from
20b44d3
to
40acc35
Compare
| val (out, err) = withNodeJsContainer { c => | ||
| val code = """ | ||
| | function main(args) { | ||
| | require('wildlyuniquenameofanonexistentpackage'); |
There was a problem hiding this comment.
But for now, thats not an issue as we are controlling which packages are available - so it was a mistake on my side - looks good to me otherwise :)
EDIT: somehow my first comment got deleted, I am on mobile.. I was just pointing out that this test might fail if someone registers "wildlyuniquename.." as a module
| val (out, err) = withNodeJsContainer { c => | ||
| val code = """ | ||
| | function main(args) { | ||
| | require('.mildlyinvalidnameofanonexistentpackage'); |
There was a problem hiding this comment.
@danielfederschmidt I think your point is still technically valid, and the change was easy enough to make, so I went ahead and did it 😉
|
@rabbah @bjustin-ibm created an issue to track change that need to sync with bluemix docs. |
|
PG 324 |
|
LGTM, is this good to merge documentation wise? |
|
@markusthoemmes yes, this is ready for merge. |
|
rebased and merged 364e61a |
Resolves #268