-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm version for ow-utils docker #5261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugy718 Thank you for handling this.
I could reproduce the issue and confirm this change address it.
After merging this PR, we need to update the image tag in the openwhisk-kube-deploy too.
https://github.com/apache/openwhisk-deploy-kube/blob/6040764b30ddc688d7707d5169c6f24fbed7ad6c/helm/openwhisk/values.yaml#L154
That's right. Once the image is pushed to Dockerhub, I can check again and submit a PR to update there as well. |
|
Codecov Report
@@ Coverage Diff @@
## master #5261 +/- ##
==========================================
- Coverage 80.29% 75.12% -5.17%
==========================================
Files 238 238
Lines 14059 14066 +7
Branches 570 574 +4
==========================================
- Hits 11288 10567 -721
- Misses 2771 3499 +728
Continue to review full report at Codecov.
|
Fix Issue#5260
Description
I encountered this problem and raised the issue#5260. In short, the install-package pods deployed via openwhisk-deploy-kube project helm charts fails due to using the default npm installed by apt to install alarm package. This PR basically update the npm in docker image ow-utils which is used by the install-package pod.
I have built the image with
./gradlew tools:ow-utils:distDocker
, pushed my own repository, and configure the helm charts to use it. And I can successfully deploy openwhisk on my kubernetes cluster again.Related issue and scope
My changes affect the following components
Types of changes
Checklist: