Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm version for ow-utils docker #5261

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

hugy718
Copy link
Contributor

@hugy718 hugy718 commented Jun 21, 2022

Fix Issue#5260

Description

I encountered this problem and raised the issue#5260. In short, the install-package pods deployed via openwhisk-deploy-kube project helm charts fails due to using the default npm installed by apt to install alarm package. This PR basically update the npm in docker image ow-utils which is used by the install-package pod.

I have built the image with ./gradlew tools:ow-utils:distDocker, pushed my own repository, and configure the helm charts to use it. And I can successfully deploy openwhisk on my kubernetes cluster again.

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA. (pending reply from ASF)
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugy718 Thank you for handling this.
I could reproduce the issue and confirm this change address it.

After merging this PR, we need to update the image tag in the openwhisk-kube-deploy too.
https://github.com/apache/openwhisk-deploy-kube/blob/6040764b30ddc688d7707d5169c6f24fbed7ad6c/helm/openwhisk/values.yaml#L154

@hugy718
Copy link
Contributor Author

hugy718 commented Jun 22, 2022

@hugy718 Thank you for handling this. I could reproduce the issue and confirm this change address it.

After merging this PR, we need to update the image tag in the openwhisk-kube-deploy too. https://github.com/apache/openwhisk-deploy-kube/blob/6040764b30ddc688d7707d5169c6f24fbed7ad6c/helm/openwhisk/values.yaml#L154

That's right. Once the image is pushed to Dockerhub, I can check again and submit a PR to update there as well.

@style95
Copy link
Member

style95 commented Jun 23, 2022

It seems no check is running for this PR.
It works now after closing and reopening this.

@style95 style95 closed this Jun 23, 2022
@style95 style95 reopened this Jun 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #5261 (e653888) into master (80de54e) will decrease coverage by 5.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5261      +/-   ##
==========================================
- Coverage   80.29%   75.12%   -5.17%     
==========================================
  Files         238      238              
  Lines       14059    14066       +7     
  Branches      570      574       +4     
==========================================
- Hits        11288    10567     -721     
- Misses       2771     3499     +728     
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0.00% <0.00%> (-78.58%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0.00% <0.00%> (-74.08%) ⬇️
...ore/database/azblob/AzureBlobAttachmentStore.scala 11.53% <0.00%> (-60.58%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80de54e...e653888. Read the comment docs.

@style95 style95 merged commit c5970a6 into apache:master Jun 23, 2022
@hugy718 hugy718 deleted the issue#5260 branch July 5, 2022 05:51
JesseStutler pushed a commit to JesseStutler/openwhisk that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants