[Scheduler Enhancement] Remove deleted containers. #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningyougang
reviewed
Jul 4, 2022
| @@ -593,7 +593,8 @@ object LoggingMarkers { | |||
| val SCHEDULER_KAFKA = LogMarkerToken(scheduler, kafka, start)(MeasurementUnit.time.milliseconds) | |||
| val SCHEDULER_KAFKA_WAIT_TIME = | |||
| LogMarkerToken(scheduler, "kafkaWaitTime", counter)(MeasurementUnit.none) | |||
| def SCHEDULER_WAIT_TIME(action: String) = LogMarkerToken(scheduler, "waitTime", counter, Some(action), Map("action" -> action))(MeasurementUnit.none) | |||
| def SCHEDULER_WAIT_TIME(action: String) = | |||
| LogMarkerToken(scheduler, "waitTime", counter, Some(action), Map("action" -> action))(MeasurementUnit.none) | |||
There was a problem hiding this comment.
Seems the content is same, just do format.
Normally, the time unit should be MeasurementUnit.time.milliseconds, why here MeasurementUnit.none?
There was a problem hiding this comment.
I just kept the original one.
I would update it.
ningyougang
approved these changes
Jul 4, 2022
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #5265 +/- ##
==========================================
- Coverage 80.27% 75.14% -5.14%
==========================================
Files 238 238
Lines 14066 14080 +14
Branches 574 576 +2
==========================================
- Hits 11292 10580 -712
- Misses 2774 3500 +726
Continue to review full report at Codecov.
|
JesseStutler
pushed a commit
to JesseStutler/openwhisk
that referenced
this pull request
Jul 13, 2022
* Apply ScalaFmt. * Do not send messages to deleted containers. * Use milliseconds as a measurement unit. * Fix test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When some containers are terminated as they are idle, a memory queue still sends activations to them as their request are in the buffer.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: