Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler inProgressJobRetention parsing #5281

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

hunhoffe
Copy link
Contributor

Description

In the recent commit, inProgressJobRetention is parsed as an integer. However, in places such as ansible/group_vars/all and src/test/resources/application.conf.j2 it was defined as a Duration (e.g., default is '20 seconds')

This PR is to change inProgressJobRetention to be parsed as a duration.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@hunhoffe hunhoffe marked this pull request as ready for review July 13, 2022 12:59
@style95
Copy link
Member

style95 commented Jul 14, 2022

Thank you for handling this.

@style95 style95 merged commit 4016aa8 into apache:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants