Add a documentation for warmed containers configurations. #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style95
requested review from
bdoyle0182,
jiangpengcheng,
KeonHee,
ningyougang and
upgle
style95
force-pushed
the
warmed-containers-doc
branch
from
9c9aacb
to
0d6061f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5282 +/- ##
==========================================
- Coverage 80.08% 75.35% -4.74%
==========================================
Files 238 238
Lines 14122 14122
Branches 589 589
==========================================
- Hits 11310 10642 -668
- Misses 2812 3480 +668
Continue to review full report at Codecov.
|
ningyougang
approved these changes
Jul 14, 2022
jiangpengcheng
approved these changes
Jul 14, 2022
bdoyle0182
reviewed
Jul 14, 2022
|
|
||
| ## Configuration | ||
|
|
||
| The configurations are only effective with the FPC scheduler. |
There was a problem hiding this comment.
this isn't totally true since some of the configurations already existed right?
There was a problem hiding this comment.
warmedContainerKeepingCount and warmedContainerKeepingTimeout are only effective in FPContainerProxy.
bdoyle0182
reviewed
Jul 14, 2022
| allowedKinds: Option[Set[String]] = None, | ||
| storeActivations: Option[Boolean] = None, | ||
| warmedContainerKeepingCount: Option[Int] = None, | ||
| warmedContainerKeepingTimeout: Option[String] = None) |
There was a problem hiding this comment.
This overrides the system wide idle timeout? I didn't even know this existed
There was a problem hiding this comment.
Yes, so do I. So I added them.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to add documentation about the configurations for warmed containers.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: