Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs golang broken markdown link #5345

Merged
merged 3 commits into from
Feb 18, 2023

Conversation

jonasbn
Copy link
Contributor

@jonasbn jonasbn commented Nov 1, 2022

Description

While reading the documentation I fell over some malformed/broken Markdown

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@style95
Copy link
Member

style95 commented Nov 1, 2022

@jonasbn Thank you for your first contribution.
Have you submitted the Apache iCLA form?

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Merging #5345 (1bc6a19) into master (07c9202) will increase coverage by 37.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5345       +/-   ##
===========================================
+ Coverage   38.96%   76.08%   +37.12%     
===========================================
  Files         240      241        +1     
  Lines       14378    15427     +1049     
  Branches      614      672       +58     
===========================================
+ Hits         5602    11738     +6136     
+ Misses       8776     3689     -5087     
Impacted Files Coverage Δ
...pache/openwhisk/core/invoker/InvokerReactive.scala 53.90% <0.00%> (-17.97%) ⬇️
...ache/openwhisk/core/database/DocumentFactory.scala 100.00% <0.00%> (ø)
...scala/org/apache/openwhisk/http/CorsSettings.scala 100.00% <0.00%> (ø)
.../org/apache/openwhisk/core/entity/EntityPath.scala 100.00% <0.00%> (+1.88%) ⬆️
...apache/openwhisk/core/entitlement/Collection.scala 88.37% <0.00%> (+2.32%) ⬆️
...la/org/apache/openwhisk/core/invoker/Invoker.scala 72.50% <0.00%> (+2.50%) ⬆️
.../org/apache/openwhisk/http/PoolingRestClient.scala 90.90% <0.00%> (+3.03%) ⬆️
...hisk/core/controller/actions/SequenceActions.scala 91.86% <0.00%> (+3.25%) ⬆️
...sk/core/containerpool/docker/DockerContainer.scala 95.60% <0.00%> (+3.29%) ⬆️
...la/org/apache/openwhisk/common/TransactionId.scala 94.38% <0.00%> (+3.37%) ⬆️
... and 151 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonasbn
Copy link
Contributor Author

jonasbn commented Nov 1, 2022

Hi @style95

Yes, I have signed the iCLA form and submitted it.

Anything else I need to do?

@style95 style95 closed this Jan 25, 2023
@style95 style95 reopened this Jan 25, 2023
@style95
Copy link
Member

style95 commented Feb 18, 2023

I am merging this as the Travis build is no longer valid.

@style95 style95 merged commit 2358976 into apache:master Feb 18, 2023
mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
* Corrected broken Markdown link

* Corrected broken Markdown link

(cherry picked from commit 2358976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants