GitHub action #5361

msciabarra · 2022-12-08T19:58:15Z

Implements a port of the travis build for github actions

Description

This adds a Github action workflow and a port of the travis scripts to work with GitHubactions

Travis needs to be replaced

Related issue and scope

I opened an issue to propose and discuss this change (Migrate to GitHub Action because Travis ends support for open source. #5360)

My changes affect the following components

Types of changes

Bug fix (generally a non-breaking change which closes an issue).
Enhancement or new feature (adds new functionality).
Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

I signed an Apache CLA.
I reviewed the style guides and followed the recommendations (Travis CI will check :).
I added tests to cover my changes.
My changes require further changes to the documentation.
I updated the documentation where necessary.

msciabarra · 2022-12-08T19:59:05Z

Please note it is still incomplete because I have no idea of how to upload logs and how to see the results.

codecov-commenter · 2022-12-08T20:39:09Z

Codecov Report

Merging #5361 (7fbcb1b) into master (8578887) will decrease coverage by 24.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5361       +/-   ##
===========================================
- Coverage   81.46%   57.36%   -24.10%     
===========================================
  Files         240      240               
  Lines       14407    14407               
  Branches      618      601       -17     
===========================================
- Hits        11736     8264     -3472     
- Misses       2671     6143     +3472

Impacted Files	Coverage Δ
...a/org/apache/openwhisk/common/ConfigMapValue.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...hisk/core/database/cosmosdb/ReferenceCounted.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...core/database/cosmosdb/RxObservableImplicits.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...re/database/cosmosdb/CollectionResourceUsage.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...hisk/core/database/mongodb/MongoDBViewMapper.scala	`0.00% <0.00%> (-98.89%)`	⬇️
...apache/openwhisk/core/database/LimitsCommand.scala	`0.00% <0.00%> (-98.51%)`	⬇️
... and 144 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

.github/workflows/unit.yaml

.github/workflows/performance.yaml

style95 · 2022-12-10T01:10:38Z

Logs are uploaded to IBM Bluemix.
https://github.com/apache/openwhisk/blob/master/tools/travis/box-upload.py#L46

We need to see if this is still valid.
I also have no access to the logs.

@dgrove-oss, could you confirm if we can still use Bluemix to upload logs?

sciabarracom · 2022-12-10T07:55:26Z

Yes I see in the scripts there is a "box-upload.py" script uploading them to a wired-in path. I am going to add also s3 upload so if you provide your keys it will upload to s3 instead.

…

-- Michele Sciabarra ***@***.***

----- Original message ----- From: Dominic Kim ***@***.***> To: apache/openwhisk ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [apache/openwhisk] GitHub action [WIP] (PR #5361) Date: Saturday, December 10, 2022 1:10 AM Logs are uploaded to IBM Bluemix. https://github.com/apache/openwhisk/blob/master/tools/travis/box-upload.py#L46 We need to see if this is still valid. I also have no access to the logs. @dgrove-oss <https://github.com/dgrove-oss>, could you confirm if we can still use Bluemix to upload logs? — Reply to this email directly, view it on GitHub <#5361 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHJ4D36OOAHDQB3MFXMVPALWMPKCHANCNFSM6AAAAAASYRAF5Q>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

msciabarra · 2022-12-11T18:39:42Z

I updated the pull requests.

It is now able to write on slack and upload logs to an S3 buckets.
There is also an "on demand" task allowing to launch a single test and debug the results enabling and accessing the vm with ngrok.

To use the PR we need to merge it and also add to GitHub all the secrets listed in the .github/workflows/README.

style95 · 2022-12-12T09:21:05Z

How can we test this change?
It seems the GitHub workflow is not running on this repo.

msciabarra · 2022-12-12T09:28:44Z

The workflow does not run and it is not visibile until it is available on the default branch so it shoud be merged. However currently the do not run unless you trigger them manually or push a tag. So we can test them merging and triggering manually. Or you can merge them in a fork as I am doing here (https://github.com/msciabarra/openwhisk/)

ansible/group_vars/all

…aming S3_LOG_BUCKET to AWS_BUCKET to fix tests

msciabarra · 2022-12-12T19:52:17Z

I fixed the error in the aws storage renaming a secret to AWS_BUCKET, and the error in system forcing a corresponding java version. I had to "slightly" update the version of openj9 used to use one that can be actually downloaded (11.0.8 -> 11.0.12)

msciabarra · 2022-12-13T07:38:07Z

Now I have unit, multiruntime and standalone test passing and system only failing one test

msciabarra · 2022-12-13T20:39:10Z

The build is able to pass all the tests on 1.0.0 so I assume it can be merged.

style95

It seems this change is aligned with 1.0.0.
Is this will be updated to be aligned with the current master?

ansible/group_vars/all

msciabarra · 2022-12-14T08:24:42Z

more cleanup added, removed all the changed files to fix 1.0.0, now triggered by push and pull-requests without tags

bdoyle0182 · 2022-12-14T17:07:08Z

To Dom's comment on aligning with master past 1.0.0 and the email sent to the dev list, I don't think master is broken. The CI tests should all pass, I think there was some flakiness with travis / the scheduler tests that would require you to re-kick the travis job to get them to pass; but master should be in a fine state.

Thank you so much for the effort on this before the holidays.

msciabarra · 2022-12-14T18:01:28Z

Yes, I confirm the master is NOT broken. Indeed I was able to run all the master tests against my fork. At this point I think it is safe to merge.

msciabarra · 2022-12-14T18:04:53Z

Sorry my mistake. Please merge now. I tested the build against my fork and it works.

style95

Thanks, @msciabarra
This is great work!

Generally LGTM with minor questions.

.github/workflows/0-on-demand.yaml

style95 · 2022-12-15T01:30:58Z

.github/workflows/0-on-demand.yaml

+  SLACK_WEBHOOK: ${{secrets.SLACK_WEBHOOK}}
+
+  # (optional) s3 log upload
+  AWS_BUCKET: ${{ secrets.AWS_BUCKET }}


Same for NGROK, so now contributors are in charge of uploading logs to their own environment to figure out the failed tests of a PR.
For periodic tests against the upstream master branch, those who have permission can configure proper secrets for the upstream repo.

It needs to be discussed where to place such logs.

Yes you can put your own AWS_BUCKET where you want. The bucket can be made public as I did here: https://nuvolaris-logs.s3.eu-central-1.amazonaws.com/index.html.
Instructions are in the README.
Actually, since there is already a bucket configured for some tests, it will be used!
Maybe this is not what the owner of the bucket wants.
We need to get a bucket from Amazon or from some other cloud provider, I am sure there are donations somewhere of resources that we can use...

style95 · 2022-12-15T01:35:02Z

.github/workflows/README.md

+
+If you want to get notified of what happens on slack, create an [Incoming Web Hook](https://api.slack.com/messaging/webhooks) and then set the following secret:
+
+- `SLACK_WEBHOOK`: the incoming webhook url provided by slack.


I think this is also same. It would be great to discuss how/whether to configure this for the upstream repo.

You can use it with the current OpenWhisk slack. I do not know who has access to the slack configuration. All you need to do is to create an app and retrieve the incoming webhook. And you can use the exiting dev channel on OpenWhisk slack

style95 · 2022-12-15T01:37:47Z

tools/github/runDummyTests.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash


What is the purpose of this?
Seems it's being used here.
https://github.com/apache/openwhisk/pull/5361/files#diff-fc5257f5200a46b6baab3ca657b694cc84dc77e3a5f9d71062b25fce994c02b4R70

to test the build without having to run a full test... it is handy to debug secrets and so on

style95 · 2022-12-15T01:40:15Z

tools/github/setup.sh

+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]


This might need to be deleted?

no, if you do not want to defeat the goal of the dummy test to avoid to run a fast build withou waiting an hour...

I love this idea to skip tests for debugging.
How about making this as an input as well just like debugging enablement option so that users can easily trigger this feature without changing any code?

it is already there...if you launvh the dummy build and enable ngrok in a few second you get an ssh command to get into the vm with everythingalready setup to build and test.

Can we control whether to run these dummy tests like this?

Also, there is the same code block, so can we delete these comments?
https://github.com/apache/openwhisk/pull/5361/files#diff-fc5257f5200a46b6baab3ca657b694cc84dc77e3a5f9d71062b25fce994c02b4R70

Yes you control the test from there. Select "Dummy" to run the dummy test. It is useful when also you enable Ngrok debugging so you get an ssh command to get into the CI build VM to experiment.

ah ok, I got confused.
My last question is what is the purpose of this commented block?
There is already uncommented one.

if [[ $TEST_SUITE =~ Dummy ]] then echo skiping setup ; exit 0 fi```

tools/github/setup.sh

tools/github/runDummyKOTests.sh

style95 · 2022-12-16T04:44:09Z

.../test/scala/org/apache/openwhisk/core/containerpool/v2/test/ActivationClientProxyTests.scala

@@ -15,6 +15,7 @@
 * limitations under the License.
 */

+/*


Why is this test commented?

it was an attempt to pass the travis build to merge... but looks like it does not work

style95 · 2022-12-16T04:47:38Z

tools/github/setup.sh

+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]


Can we control whether to run these dummy tests like this?

Also, there is the same code block, so can we delete these comments?
https://github.com/apache/openwhisk/pull/5361/files#diff-fc5257f5200a46b6baab3ca657b694cc84dc77e3a5f9d71062b25fce994c02b4R70

msciabarra · 2022-12-16T10:53:06Z

Definitely ready to merge. This is what I get on my fork:

All tests are passing.

michele-sciabarra added 13 commits December 8, 2022 19:50

github action initial commit

2964ff0

fix blank

e2177d3

debug

5aa489a

fix push

57f76fd

fix java

3bdc6cd

add setup

f400f1e

triggering build

44d4d24

run unit test

0c8993a

ooops

906b1a0

updating debugAction

5c421d1

waitifdebug

1408f81

fix cleanup

fc4212d

final test

880ab52

disable ngrok

3150456

michele-sciabarra added 2 commits December 9, 2022 06:07

reworked the PR - multiple jobs and slack

b1534d0

split in multiple build

f8cec72

style95 reviewed Dec 10, 2022

View reviewed changes

.github/workflows/unit.yaml Outdated Show resolved Hide resolved

.github/workflows/performance.yaml Outdated Show resolved Hide resolved

github actions updated

0da4b9f

msciabarra changed the title ~~GitHub action [WIP]~~ GitHub action Dec 11, 2022

scancode fixes

fe8cf67

bdoyle0182 reviewed Dec 12, 2022

View reviewed changes

ansible/group_vars/all Outdated Show resolved Hide resolved

forcing a corresponding version of jdk in ci and docker image and ren…

00308f9

…aming S3_LOG_BUCKET to AWS_BUCKET to fix tests

finally passing all the tests on 1.0.0

e699537

style95 reviewed Dec 14, 2022

View reviewed changes

ansible/group_vars/all Outdated Show resolved Hide resolved

michele-sciabarra added 4 commits December 14, 2022 07:52

restored master variables

69be259

restored more master files

e16ad25

triggered on push and pull request

268730f

unit test too

bfb71a2

michele-sciabarra added 6 commits December 14, 2022 11:57

wskadmin fixes

be2b928

improve message

fcd7a84

dummy enabled

8914674

better git message

69a8043

cleanup the log messages

5e47a4d

unnecessary change to master - even if beneficial

44eb282

msciabarra closed this Dec 14, 2022

msciabarra reopened this Dec 14, 2022

bdoyle0182 approved these changes Dec 14, 2022

View reviewed changes

bdoyle0182 closed this Dec 14, 2022

bdoyle0182 reopened this Dec 14, 2022

style95 reviewed Dec 15, 2022

View reviewed changes

improved messages (and a test disabled)

7fbcb1b

style95 reviewed Dec 16, 2022

View reviewed changes

michele-sciabarra added 2 commits December 16, 2022 07:53

reverting commented test

6e37559

get rid of DummyKO no more needed

9647cdc

sciabarracom merged commit f717619 into apache:master Dec 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub action #5361

GitHub action #5361

msciabarra commented Dec 8, 2022

msciabarra commented Dec 8, 2022

codecov-commenter commented Dec 8, 2022 •

edited

Loading

style95 commented Dec 10, 2022

sciabarracom commented Dec 10, 2022 via email

msciabarra commented Dec 11, 2022

style95 commented Dec 12, 2022

msciabarra commented Dec 12, 2022

msciabarra commented Dec 12, 2022

msciabarra commented Dec 13, 2022

msciabarra commented Dec 13, 2022

style95 left a comment

msciabarra commented Dec 14, 2022

bdoyle0182 commented Dec 14, 2022

msciabarra commented Dec 14, 2022 •

edited

Loading

msciabarra commented Dec 14, 2022

style95 left a comment

style95 Dec 15, 2022

msciabarra Dec 15, 2022

style95 Dec 15, 2022

msciabarra Dec 15, 2022

style95 Dec 15, 2022

msciabarra Dec 15, 2022

style95 Dec 15, 2022

msciabarra Dec 15, 2022

style95 Dec 16, 2022

msciabarra Dec 16, 2022

style95 Dec 16, 2022

msciabarra Dec 16, 2022

style95 Dec 16, 2022 •

edited

Loading

style95 Dec 16, 2022

msciabarra Dec 16, 2022

style95 Dec 16, 2022

msciabarra commented Dec 16, 2022


		If you want to get notified of what happens on slack, create an [Incoming Web Hook](https://api.slack.com/messaging/webhooks) and then set the following secret:

		- `SLACK_WEBHOOK`: the incoming webhook url provided by slack.

GitHub action #5361

GitHub action #5361

Conversation

msciabarra commented Dec 8, 2022

Description

Related issue and scope

My changes affect the following components

Types of changes

Checklist:

msciabarra commented Dec 8, 2022

codecov-commenter commented Dec 8, 2022 • edited Loading

Codecov Report

style95 commented Dec 10, 2022

sciabarracom commented Dec 10, 2022 via email

msciabarra commented Dec 11, 2022

style95 commented Dec 12, 2022

msciabarra commented Dec 12, 2022

msciabarra commented Dec 12, 2022

msciabarra commented Dec 13, 2022

msciabarra commented Dec 13, 2022

style95 left a comment

Choose a reason for hiding this comment

msciabarra commented Dec 14, 2022

bdoyle0182 commented Dec 14, 2022

msciabarra commented Dec 14, 2022 • edited Loading

msciabarra commented Dec 14, 2022

style95 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

style95 Dec 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msciabarra commented Dec 16, 2022

codecov-commenter commented Dec 8, 2022 •

edited

Loading

msciabarra commented Dec 14, 2022 •

edited

Loading

style95 Dec 16, 2022 •

edited

Loading