Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback logback minor upgrade to latest patch #5380

Merged
merged 1 commit into from Feb 15, 2023

Conversation

bdoyle0182
Copy link
Contributor

Description

The dependency upgrade I merged in over the weekend has an issue with the logback minor upgrade. It seems the package is built past jdk8 and fails at runtime when trying to run with jdk8. I don't think a full revert is necessary since validated things look good now just going forward to the latest patch which I think still covers the cve.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #5380 (44162c0) into master (084c2ad) will decrease coverage by 0.95%.
The diff coverage is n/a.

❗ Current head 44162c0 differs from pull request most recent head c9ad52f. Consider uploading reports for the commit c9ad52f to get more accurate results

@@            Coverage Diff             @@
##           master    #5380      +/-   ##
==========================================
- Coverage   76.77%   75.83%   -0.95%     
==========================================
  Files         240      240              
  Lines       14569    14569              
  Branches      647      647              
==========================================
- Hits        11185    11048     -137     
- Misses       3384     3521     +137     
Impacted Files Coverage Δ
...whisk/connector/kafka/KafkaConsumerConnector.scala 59.15% <0.00%> (-22.54%) ⬇️
.../scala/org/apache/openwhisk/utils/Exceptions.scala 20.00% <0.00%> (-20.00%) ⬇️
...pache/openwhisk/core/invoker/InvokerReactive.scala 53.07% <0.00%> (-18.47%) ⬇️
...rg/apache/openwhisk/core/controller/Triggers.scala 81.37% <0.00%> (-13.11%) ⬇️
...hisk/core/controller/actions/SequenceActions.scala 82.11% <0.00%> (-9.76%) ⬇️
...sk/core/containerpool/docker/DockerContainer.scala 90.36% <0.00%> (-8.44%) ⬇️
...g/apache/openwhisk/common/ResizableSemaphore.scala 92.30% <0.00%> (-7.70%) ⬇️
...core/controller/BasicAuthenticationDirective.scala 92.30% <0.00%> (-7.70%) ⬇️
...whisk/connector/kafka/KafkaProducerConnector.scala 56.09% <0.00%> (-4.88%) ⬇️
...la/org/apache/openwhisk/core/etcd/EtcdClient.scala 55.38% <0.00%> (-4.62%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgrove-oss dgrove-oss merged commit 3ea756f into apache:master Feb 15, 2023
@bdoyle0182 bdoyle0182 deleted the rollback-logback branch February 16, 2023 19:26
mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
Co-authored-by: Brendan Doyle <brendand@qualtrics.com>
(cherry picked from commit 3ea756f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants