Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ngrok to v3 #5465

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Update ngrok to v3 #5465

merged 1 commit into from
Feb 24, 2024

Conversation

style95
Copy link
Member

@style95 style95 commented Feb 14, 2024

Description

Upgrade the version of ngrok to v3.
It is required to run the on-demand workflow to debug CI tests.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@style95 style95 changed the title Update the ngrok to v3 Update ngrok to v3 Feb 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aea3a88) 76.60% compared to head (19841b0) 76.50%.

❗ Current head 19841b0 differs from pull request most recent head 09921e2. Consider uploading reports for the commit 09921e2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5465      +/-   ##
==========================================
- Coverage   76.60%   76.50%   -0.11%     
==========================================
  Files         241      241              
  Lines       14650    14650              
  Branches      644      644              
==========================================
- Hits        11223    11208      -15     
- Misses       3427     3442      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@style95 style95 merged commit 5529cc4 into apache:master Feb 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants