ORC-1089: Add test cases verifying writers with selected vector #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
|
cc @williamhyun , too |
|
Thank you, @guiyanakuang and @wgtmac . Merged to main. |
dongjoon-hyun
approved these changes
Jan 14, 2022
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
…he#1009) ### What changes were proposed in this pull request? This pr aims to add test cases specifically to check that writers support the selected vector feature. `testWriteBaseTypeUseSelectedVector`: For covering base types. `testWriteComplexTypeUseSelectedVector`: For covering multiple nested types. `testWriteRepeatedUseSelectedVector`: For covering repeated values. `testWriteEncryptionUseSelectedVector`: For covering field encryption. Test the idea that the value written to one field is associated with the row number and that the other fields are obtained by some transformation of the value of this field. The feature is guaranteed to be correct by checking the selected row number against the read result. ### Why are the changes needed? Enrich test cases to ensure robustness of feature. ### How was this patch tested? Pass the commit test cases. Currently marked as disabled first until https://github.com/apache/orc/pull/994/files merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to add test cases specifically to check that writers support the selected vector feature.
testWriteBaseTypeUseSelectedVector: For covering base types.testWriteComplexTypeUseSelectedVector: For covering multiple nested types.testWriteRepeatedUseSelectedVector: For covering repeated values.testWriteEncryptionUseSelectedVector: For covering field encryption.Test the idea that the value written to one field is associated with the row number and that the other fields are obtained by some transformation of the value of this field. The feature is guaranteed to be correct by checking the selected row number against the read result.
Why are the changes needed?
Enrich test cases to ensure robustness of feature.
How was this patch tested?
Pass the commit test cases. Currently marked as disabled first until https://github.com/apache/orc/pull/994/files merged