ORC-1127: [C++] add missing version of UNSTABLE-PRE-2.0 #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiga-huang
changed the title
dongjoon-hyun
approved these changes
Mar 15, 2022
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 15, 2022
### What changes were proposed in this pull request? This adds the UNSTABLE-PRE-2.0 version in the c++ client. It's part of #1062 but now extracted for easy backporting. Ref: #1062 (comment) ### Why are the changes needed? Without this change, the C++ client will read the UNSTABLE-PRE-2.0 version as 1.9999, which is inconsistent with the Java client. See examples in the JIRA description. ### How was this patch tested? Add unit test in TestFileMetadata.cc with a test file generated by Hive. (cherry picked from commit 9d45c92) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
cc @williamhyun since he is the release manager of Apache ORC 1.7.4. |
stiga-huang
added a commit
to stiga-huang/orc
that referenced
this pull request
May 4, 2022
### What changes were proposed in this pull request? This adds the UNSTABLE-PRE-2.0 version in the c++ client. It's part of apache#1062 but now extracted for easy backporting. Ref: apache#1062 (comment) ### Why are the changes needed? Without this change, the C++ client will read the UNSTABLE-PRE-2.0 version as 1.9999, which is inconsistent with the Java client. See examples in the JIRA description. ### How was this patch tested? Add unit test in TestFileMetadata.cc with a test file generated by Hive.
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This adds the UNSTABLE-PRE-2.0 version in the c++ client. It's part of apache#1062 but now extracted for easy backporting. Ref: apache#1062 (comment) ### Why are the changes needed? Without this change, the C++ client will read the UNSTABLE-PRE-2.0 version as 1.9999, which is inconsistent with the Java client. See examples in the JIRA description. ### How was this patch tested? Add unit test in TestFileMetadata.cc with a test file generated by Hive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This adds the UNSTABLE-PRE-2.0 version in the c++ client. It's part of #1062 but now extracted for easy backporting.
Ref: #1062 (comment)
Why are the changes needed?
Without this change, the C++ client will read the UNSTABLE-PRE-2.0 version as 1.9999, which is inconsistent with the Java client. See examples in the JIRA description.
How was this patch tested?
Add unit test in TestFileMetadata.cc with a test file generated by Hive.