ORC-1128: [C++] Replace protobuf::MessageLite::ByteSize() with ByteSi… #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @wzhou-code and @stiga-huang ! |
|
Hi, @wgtmac . You can assign ORC-1128 to @wzhou-code after you add him to the Apache ORC contributor group with your admin permission. Please try here. I leave that to you, @wgtmac . :) |
|
Done. Thanks @dongjoon-hyun for the guide! |
Closed
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
…zeLong() This fixes apache#1065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zeLong()
What changes were proposed in this pull request?
Replace protobuf::MessageLite::ByteSize() with protobuf::MessageLite::ByteSizeLong() in c++ test code.
Why are the changes needed?
protobuf::MessageLite::ByteSize() was deprecated in protobuf library. It should be replaced with protobuf::MessageLite::ByteSizeLong() since it could cause build failure when building orc with new version of protobuf library.
How was this patch tested?
Passed orc-test and tool-test.