ORC-1228: Fix setAttribute to handle null value
#1196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhyun
changed the title
setAttribute to handle null value
|
cc: @dongjoon-hyun |
dongjoon-hyun
approved these changes
Jul 26, 2022
|
Feel free to merge and backport, @williamhyun . You are the release manager of Apache ORC 1.7.6. |
williamhyun
added a commit
that referenced
this pull request
Jul 26, 2022
### What changes were proposed in this pull request? This PR aims to fix `setAttribute` to handle null value. ### Why are the changes needed? In case of clearing the value with null, we should remove the corresponding key also to save memory. ### How was this patch tested? Pass the CIs with the new test case. Closes #1196 from williamhyun/setattributenull. Authored-by: William Hyun <william@apache.org> Signed-off-by: William Hyun <william@apache.org> (cherry picked from commit fbcbac5) Signed-off-by: William Hyun <william@apache.org>
williamhyun
added a commit
that referenced
this pull request
Jul 26, 2022
### What changes were proposed in this pull request? This PR aims to fix `setAttribute` to handle null value. ### Why are the changes needed? In case of clearing the value with null, we should remove the corresponding key also to save memory. ### How was this patch tested? Pass the CIs with the new test case. Closes #1196 from williamhyun/setattributenull. Authored-by: William Hyun <william@apache.org> Signed-off-by: William Hyun <william@apache.org> (cherry picked from commit fbcbac5) Signed-off-by: William Hyun <william@apache.org>
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to fix `setAttribute` to handle null value. ### Why are the changes needed? In case of clearing the value with null, we should remove the corresponding key also to save memory. ### How was this patch tested? Pass the CIs with the new test case. Closes apache#1196 from williamhyun/setattributenull. Authored-by: William Hyun <william@apache.org> Signed-off-by: William Hyun <william@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
setAttributeto handle null value.Why are the changes needed?
In case of clearing the value with null, we should remove the corresponding key also to save memory.
How was this patch tested?
Pass the CIs with the new test case.