Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1237: Remove a wrong image link to article-footer.png #1208

Closed
wants to merge 1 commit into from

Conversation

williamhyun
Copy link
Member

@williamhyun williamhyun commented Aug 4, 2022

What changes were proposed in this pull request?

This Pr aims to remove a wrong image link to article-footer.png.

Why are the changes needed?

Currently, this missing image link shows a 404 error.

How was this patch tested?

Manually.

@williamhyun williamhyun changed the title ORC-1237: Remove a wrong image link to article-footer.png ORC-1237: Remove a wrong image link to article-footer.png Aug 4, 2022
@github-actions github-actions bot added the DOCS label Aug 4, 2022
@williamhyun
Copy link
Member Author

cc: @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

dongjoon-hyun pushed a commit that referenced this pull request Aug 4, 2022
### What changes were proposed in this pull request?
This Pr aims to remove a wrong image link to `article-footer.png`.

### Why are the changes needed?
Currently, this missing image link shows a 404 error.

### How was this patch tested?
Manually.

Closes #1208 from williamhyun/siteimage.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit da1c82d)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun pushed a commit that referenced this pull request Aug 4, 2022
### What changes were proposed in this pull request?
This Pr aims to remove a wrong image link to `article-footer.png`.

### Why are the changes needed?
Currently, this missing image link shows a 404 error.

### How was this patch tested?
Manually.

Closes #1208 from williamhyun/siteimage.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit da1c82d)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun dongjoon-hyun added this to the 1.7.6 milestone Aug 4, 2022
@dongjoon-hyun
Copy link
Member

Merged to main/1.8/1.7.

cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?
This Pr aims to remove a wrong image link to `article-footer.png`.

### Why are the changes needed?
Currently, this missing image link shows a 404 error.

### How was this patch tested?
Manually.

Closes apache#1208 from williamhyun/siteimage.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants