ORC-1241: Use apache/orc-dev DockerHub repository in Docker tests
#1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @dongjoon-hyun |
dongjoon-hyun
changed the title
apache/orc-dev DockerHub repository in Docker testsapache/orc-dev DockerHub repository in Docker tests
dongjoon-hyun
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
+1, LGTM. Thank you, @williamhyun .
Let me test this manually.
|
It works perfectly. |
|
Since this is irrelevant to the GitHub Action yet, let me merge this. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 5, 2022
### What changes were proposed in this pull request? This PR aims to use `apache/orc-dev` DockerHub repository in Docker tests. ### Why are the changes needed? https://issues.apache.org/jira/browse/INFRA-23534 We should utilize the prebuilt image ### How was this patch tested? Manually. Closes #1212 from williamhyun/usedocker. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit e8a2241) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 5, 2022
### What changes were proposed in this pull request? This PR aims to use `apache/orc-dev` DockerHub repository in Docker tests. ### Why are the changes needed? https://issues.apache.org/jira/browse/INFRA-23534 We should utilize the prebuilt image ### How was this patch tested? Manually. Closes #1212 from williamhyun/usedocker. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit e8a2241) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This was referenced Aug 5, 2022
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to use `apache/orc-dev` DockerHub repository in Docker tests. ### Why are the changes needed? https://issues.apache.org/jira/browse/INFRA-23534 We should utilize the prebuilt image ### How was this patch tested? Manually. Closes apache#1212 from williamhyun/usedocker. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
apache/orc-devDockerHub repository in Docker tests.Why are the changes needed?
https://issues.apache.org/jira/browse/INFRA-23534
We should utilize the prebuilt image
How was this patch tested?
Manually.